Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#58631 #58841

Closed
rust-highfive opened this issue Mar 1, 2019 · 4 comments
Closed

miri no longer builds after rust-lang/rust#58631 #58841

rust-highfive opened this issue Mar 1, 2019 · 4 comments
Assignees
@spastorino @eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #58631, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @spastorino, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2019
@spastorino
Copy link
Member

We should now merge my miri and clippy PRs
/cc @RalfJung @oli-obk

rust-lang/miri#647
rust-lang/rust-clippy#3823

@oli-obk
Copy link
Contributor

oli-obk commented Mar 1, 2019

Already on it ;)

@RalfJung
Copy link
Member

RalfJung commented Mar 2, 2019

Miri is fixed upstream, just needs a PR here.

This was referenced Mar 2, 2019
Merged
Closed
bors added a commit that referenced this issue Mar 3, 2019
@bors
Auto merge of #58879 - spastorino:update_miri, r=oli-obk
c0086b9 
Update miri

Related to #58841

r? @RalfJung
@RalfJung
Copy link
Member

RalfJung commented Mar 3, 2019

Fixed by #58879

@RalfJung RalfJung closed this as completed Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spastorino spastorino

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@spastorino @eddyb @RalfJung @oli-obk @rust-highfive