Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#56732 #59059

Closed
rust-highfive opened this issue Mar 10, 2019 · 5 comments
Closed

miri no longer builds after rust-lang/rust#56732 #59059

rust-highfive opened this issue Mar 10, 2019 · 5 comments
Assignees
@Zoxc @eddyb @RalfJung @oli-obk
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #56732, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Zoxc, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 10, 2019
@pnkfelix
Copy link
Member

triage: P-high under assumption that miri is important piece of infrastructure.

@pnkfelix pnkfelix added P-high High priority and removed I-nominated labels Mar 14, 2019
@pnkfelix
Copy link
Member

From what I have read, it looks like rust-lang/miri#659 addressed this?

@pnkfelix
Copy link
Member

closing as fixed under assumption that rust-lang/miri#659 did the trick.

@mati865
Copy link
Contributor

mati865 commented Mar 14, 2019

@pnkfelix miri repository builds fine.
miri submodule is outdated and doesn't build but it's not big deal right now because installing it via rustup still doesn't work.

@RalfJung
Copy link
Member

Well Miri is still red at https://rust-lang-nursery.github.io/rust-toolstate/, I think we should track that here. But it's not really P-high I'd say.

@RalfJung RalfJung reopened this Mar 14, 2019
@RalfJung RalfJung removed the P-high High priority label Mar 14, 2019
@RalfJung RalfJung mentioned this issue Mar 14, 2019
Merged
bors added a commit that referenced this issue Mar 14, 2019
@bors
Auto merge of #59181 - RalfJung:miri, r=oli-obk
bc44841 
update miri

Fixes #59059

r? @oli-obk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zoxc Zoxc

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Zoxc @eddyb @pnkfelix @RalfJung @oli-obk @mati865 @rust-highfive