Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: code block within portability span is unreadable on dark theme #59261

Closed
ehuss opened this issue Mar 17, 2019 · 1 comment
Closed

rustdoc: code block within portability span is unreadable on dark theme #59261

ehuss opened this issue Mar 17, 2019 · 1 comment
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Mar 17, 2019

The portability span uses code blocks for target features, but these have a default dark background color that is unreadable on the dark theme.

image

Sample page: https://doc.rust-lang.org/nightly/core/arch/x86_64/index.html
@jonas-schievink jonas-schievink added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Mar 17, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 25, 2019
@GuillaumeGomez
Copy link
Member

Indeed, will send a fix.

@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 25, 2019
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Mar 26, 2019
@GuillaumeGomez
Rollup merge of rust-lang#59424 - GuillaumeGomez:fix-stability-css, r…
07c8348 
…=QuietMisdreavus

Fix code block display in portability element in dark theme

Fixes rust-lang#59261.

r? @QuietMisdreavus

A little screenshot:

<img width="521" alt="Screenshot 2019-03-26 at 00 37 49" src="https://user-images.githubusercontent.com/3050060/54961082-9a41c600-4f5f-11e9-8040-ae6f26d368ff.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @jonas-schievink @GuillaumeGomez