Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#59227 #59901

Closed
rust-highfive opened this issue Apr 12, 2019 · 2 comments · Fixed by #59929
Closed

miri no longer builds after rust-lang/rust#59227 #59901

rust-highfive opened this issue Apr 12, 2019 · 2 comments · Fixed by #59929
Assignees
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #59227, I observed that the tool miri no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @Zoxc, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @eddyb, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 12, 2019
@RalfJung
Copy link
Member

Miri fix: rust-lang/miri#687

I'd like to see #59733 landing before updating the submodule, as that will break Miri again.

@pnkfelix
Copy link
Member

This was automatically nominated by rust-highfive. Based on past discussion with @RalfJung about miri-prioritization, tagging as P-medium.

@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Apr 12, 2019
@RalfJung RalfJung mentioned this issue Apr 12, 2019
bors added a commit that referenced this issue Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants