Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suffixes on a tuple index are invalid #60138

Closed
Dylan-DPC-zz opened this issue Apr 20, 2019 · 2 comments · Fixed by #60186
Closed

suffixes on a tuple index are invalid #60138

Dylan-DPC-zz opened this issue Apr 20, 2019 · 2 comments · Fixed by #60186
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Dylan-DPC-zz
Copy link

from a crater run:

error: suffixes on a tuple index are invalid
[INFO] [stderr]    --> tests/common/mod.rs:133:10
[INFO] [stderr]     |
[INFO] [stderr] 133 | #[derive(Interact)]
[INFO] [stderr]     |          ^^^^^^^^ invalid suffix `usize`
[INFO] [stderr] 
[INFO] [stderr] error: proc-macro derive produced unparseable tokens
[INFO] [stderr]    --> tests/common/mod.rs:133:10
[INFO] [stderr]     |
[INFO] [stderr] 133 | #[derive(Interact)]
[INFO] [stderr]     |          ^^^^^^^^
[INFO] [stderr]

crate affected: interact (0.3.3), named-tuple (0.1.2), photonix (0.1.1), serde_tuple (0.2.2), susy-codec (3.1.0), thrift (0.12.0), zeroize (0.6.0)
authors: @da-x, @flier, @bsoptei, @kardeiz, @SUSYLABS, @apache, @tony-iqlusion
logs:
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/interact-0.3.3/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/named_tuple-0.1.2/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/photonix-0.1.1/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/serde_tuple-0.2.2/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/susy-codec-3.1.0/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/thrift-0.12.0/log.txt,
https://crater-reports.s3.amazonaws.com/beta-1.35-1/beta-2019-04-11/reg/zeroize-0.6.0/log.txt

probable duplicate of #59418
@Dylan-DPC-zz Dylan-DPC-zz added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Apr 20, 2019
@Centril
Copy link
Contributor

Centril commented Apr 20, 2019

cc #59553

@Centril
Copy link
Contributor

Centril commented Apr 20, 2019

thrift and zeroize are the regressions that are most notable here; the others don't have notable reverse dependencies.

@estebank estebank mentioned this issue Apr 22, 2019
Merged
@pietroalbini pietroalbini added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 23, 2019
@nikomatsakis nikomatsakis mentioned this issue Apr 23, 2019
Open
@Centril Centril mentioned this issue Apr 23, 2019
Closed
Centril added a commit to Centril/rust that referenced this issue Apr 24, 2019
@Centril
Rollup merge of rust-lang#60186 - estebank:accept-suffix, r=nikomatsakis
00110f1 
Temporarily accept [i|u][32|size] suffixes on a tuple index and warn

Fix rust-lang#60138.

rust-lang#59553 will need to be kept open to track the change back to rejecting this code a few versions down thee line.
Centril added a commit to Centril/rust that referenced this issue Apr 24, 2019
@Centril
Rollup merge of rust-lang#60186 - estebank:accept-suffix, r=nikomatsakis
eb4860c 
Temporarily accept [i|u][32|size] suffixes on a tuple index and warn

Fix rust-lang#60138.

rust-lang#59553 will need to be kept open to track the change back to rejecting this code a few versions down thee line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporarily accept [i|u][32|size] suffixes on a tuple index and warn estebank/rust
3 participants
@Centril @pietroalbini @Dylan-DPC-zz