Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double drop in Vec::drain_filter #60977

Closed
ExpHP opened this issue May 20, 2019 · 0 comments · Fixed by #61224
Closed

Double drop in Vec::drain_filter #60977

ExpHP opened this issue May 20, 2019 · 0 comments · Fixed by #61224
Labels
A-collections Area: `std::collection` C-bug Category: This is a bug. I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ExpHP
Copy link
Contributor

ExpHP commented May 20, 2019

The following playground originally posted by @rustonaut still demonstrates a double drop in Vec::drain_filter. This is unsound.

https://play.rust-lang.org/?gist=be84e0e74bc2eb86d81a7ad90e612ace&version=nightly&mode=debug

Originating comment: #43244 (comment)
@ExpHP ExpHP mentioned this issue May 20, 2019
Open
3 tasks
@jonas-schievink jonas-schievink added A-collections Area: `std::collection` C-bug Category: This is a bug. I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 20, 2019
@aloucks aloucks mentioned this issue May 27, 2019
Merged
aloucks added a commit to aloucks/rust that referenced this issue May 27, 2019
@aloucks
Prevent Vec::drain_filter from double dropping on panic
84ae969 
Fixes: rust-lang#60977
Aaron1011 added a commit to Aaron1011/rust that referenced this issue Jul 4, 2019
@Aaron1011
Document that ManuallyDrop::drop should not called more than once
19e3457 
Double dropping is unsound (e.g. rust-lang#60977). This commit documents the fact that `ManuallyDrop::drop` should not be called multiple times on the same instance, as it might not be immediately obvious that this counts as a use of uninitialized data.
Aaron1011 added a commit to Aaron1011/rust that referenced this issue Jul 4, 2019
@Aaron1011
Document that ManuallyDrop::drop should not called more than once
af96b1d 
Double dropping is unsound (e.g. rust-lang#60977). This commit documents the fact that `ManuallyDrop::drop` should not be called multiple times on the same instance, as it might not be immediately obvious that this counts as a use of uninitialized data.
@Aaron1011 Aaron1011 mentioned this issue Jul 4, 2019
Merged
bors added a commit that referenced this issue Jul 8, 2019
@bors
Auto merge of #61224 - aloucks:drain_filter, r=Gankro
09ab31b 
Prevent Vec::drain_filter from double dropping on panic

Fixes: #60977

The changes in this PR prevent leaking and double-panicking in addition to double-drop.

Tracking issue: #43244
Centril added a commit to Centril/rust that referenced this issue Jul 28, 2019
@Centril
Rollup merge of rust-lang#62360 - Aaron1011:patch-2, r=RalfJung
fbfd542 
Document that ManuallyDrop::drop should not called more than once

Double dropping is unsound (e.g. rust-lang#60977). This commit documents the fact that `ManuallyDrop::drop` should not be called multiple times on the same instance, as it might not be immediately obvious that this counts as a use of uninitialized data.
@Qwaz Qwaz mentioned this issue Dec 21, 2020
Closed
rodrimati1992 added a commit to rodrimati1992/abi_stable_crates that referenced this issue Dec 21, 2020
@rodrimati1992
Fixed String::retain, RVec::retain. Bumped patch version to 0.9.1 .
bfdbd14 
These methods copied their implementation from the standard library,
which had memory safety bugs discovered in
rust-lang/rust#60977 and rust-lang/rust#78498 .

This bug was reported in #44 .

Added adapted tests from std which test these bugs.
@Qwaz Qwaz mentioned this issue Dec 21, 2020
Closed
rodrimati1992 added a commit to rodrimati1992/abi_stable_crates that referenced this issue Dec 22, 2020
@rodrimati1992
0 9.1 patch (#45)
342de83 
* Fixed String::retain, RVec::retain. Bumped patch version to 0.9.1 .

These methods copied their implementation from the standard library,
which had memory safety bugs discovered in
rust-lang/rust#60977 and rust-lang/rust#78498 .

This bug was reported in #44 .

Added adapted tests from std which test these bugs.

* Updated changelog for patch
rodrimati1992 added a commit to rodrimati1992/abi_stable_crates that referenced this issue Nov 22, 2022
@rodrimati1992
0 9.1 patch (#45)
5b941e0 
* Fixed String::retain, RVec::retain. Bumped patch version to 0.9.1 .

These methods copied their implementation from the standard library,
which had memory safety bugs discovered in
rust-lang/rust#60977 and rust-lang/rust#78498 .

This bug was reported in #44 .

Added adapted tests from std which test these bugs.

* Updated changelog for patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collections Area: `std::collection` C-bug Category: This is a bug. I-unsound Issue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Vec::drain_filter from double dropping on panic aloucks/rust
2 participants
@ExpHP @jonas-schievink