Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#60827 #61240

Closed
rust-highfive opened this issue May 27, 2019 · 2 comments · Fixed by #61246
Closed

rls no longer builds after rust-lang/rust#60827 #61240

rust-highfive opened this issue May 27, 2019 · 2 comments · Fixed by #61246
Assignees
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60827, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @oli-obk, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @nnethercote, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 27, 2019
@saifali96
Copy link

@rust-highfive I just tried to update my rustc nightly, it breaks and says rls component is not available:

PS D:\work\rustexps\Rocket> rustup update
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: syncing channel updates for 'nightly-x86_64-pc-windows-msvc'
info: latest update on 2019-05-27, rust version 1.36.0-nightly (5187be620 2019-05-26)
error: component 'rls' for target 'x86_64-pc-windows-msvc' is unavailable for download for channel 'nightly'

Could the issue be also related to this one?

@oli-obk
Copy link
Contributor

oli-obk commented May 28, 2019

yes, very much related. I had a fix yesterday, but it didn't get through in time for todays nightly. Try again tomorrow

bors added a commit that referenced this issue May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants