-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hash_map::IterMut changed Send bounds with hashbrown #61357
Comments
Fix the bounds on K for the Send impl of IterMut This makes the bounds match the ones of the previous `HashMap` implementation in libstd. Fixes rust-lang/rust#61357
Fix the bounds on K for the Send impl of IterMut This makes the bounds match the ones of the previous `HashMap` implementation in libstd. cc rust-lang/rust#61357
This is fixed in hashbrown 0.4.0. |
@Amanieu Shouldn't |
Since |
@cuviper Ah, gotcha. Thanks! Sorry for the false alarm :). |
Bump hashbrown to 0.4.0 Fixes #61357 This also includes rust-lang/hashbrown#80.
I think it would be a good idea to add a run-pass to check that these auto-trait impls don't change again. |
@Aaron1011 might make sense to add them as tests to most collections. |
In 1.35,
IterMut
'sSend
requiresK: Send
, but in 1.36-beta it requiresK: Sync
. Both are auto-derived, so it must be a change in their internals. Obviously,hashbrown
is quite different than the old implementation.https://doc.rust-lang.org/1.35.0/std/collections/hash_map/struct.IterMut.html#impl-Send
https://doc.rust-lang.org/beta/std/collections/hash_map/struct.IterMut.html#impl-Send
Ditto for
ValuesMut
. I'm not sure if there's any real impact in this, but it should be considered, and perhaps audit for other similar changes.cc @Amanieu, as discussed on IRC.
The text was updated successfully, but these errors were encountered: