Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librustllvm.so missing from prefix target lib directory #6247

Closed
thomaslee opened this issue May 5, 2013 · 1 comment
Closed

librustllvm.so missing from prefix target lib directory #6247

thomaslee opened this issue May 5, 2013 · 1 comment

Comments

@thomaslee
Copy link
Contributor

Running a "make install" vs master/incoming will install librustllvm.so to the host prefix library directory, but not the target library directory. In my case, this prevented me from linking a valid Rust program against librustdoc because rustc was unable to find librustllvm.so.

The fix is a trivial change to mk/install.mk: add the following line to the rule for install-target-$(1)-host-$(2): ..., after the equivalent line for CFG_RUNTIME_$(1):

$$(Q)$$(call INSTALL_LIB,$$(TL$(1)$(2)),$$(PTL$(1)$(2)),$$(CFG_RUSTLLVM_$(1)))

On 64-bit Linux, this will drop librustllvm.so in $prefix/lib/rustc/x86_64-unknown-linux-gnu/lib along with everything else.

Happy to provide a pull request, but this appears to be a one-liner.
@emberian
Copy link
Member

@thomaslee the only way code lands in the tree is via pull request.

@thomaslee thomaslee mentioned this issue Jul 15, 2013
Closed
@bors bors closed this as completed in 60d5bb9 Jul 15, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 5, 2020
@bors
Auto merge of rust-lang#6247 - giraffate:fix_suggestion_to_add_space_…
0d2f1ae 
…in_unused_unit, r=ebroto

Fix suggestion to add unneeded space in `unused_unit`

Fix rust-lang/rust-clippy#6230

changelog: Fix suggestion to add unneeded space in `unused_unit`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install librustllvm.so to target lib directory thomaslee/rust
2 participants
@thomaslee @emberian