Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc.exe crashing during Windows build with i686-w64-mingw32 #6316

Closed
thadguidry opened this issue May 8, 2013 · 2 comments
Closed

rustc.exe crashing during Windows build with i686-w64-mingw32 #6316

thadguidry opened this issue May 8, 2013 · 2 comments

Comments

@thadguidry
Copy link
Contributor

gcc -I/home/Thad/rust/src/libuv/include -I/home/Thad/rust/src/libuv/include/uv-p
rivate -g --std=gnu89 -D_WIN32_WINNT=0x0600 -I/home/Thad/rust/src/libuv/include
-I/home/Thad/rust/src/libuv/include/uv-private -c -o /home/Thad/rust/src/libuv/
src/win/winsock.o /home/Thad/rust/src/libuv/src/win/winsock.c
gcc -I/home/Thad/rust/src/libuv/include -I/home/Thad/rust/src/libuv/include/uv-p
rivate -g --std=gnu89 -D_WIN32_WINNT=0x0600 -c /home/Thad/rust/src/libuv/src/fs-
poll.c -o src/fs-poll.o
gcc -I/home/Thad/rust/src/libuv/include -I/home/Thad/rust/src/libuv/include/uv-p
rivate -g --std=gnu89 -D_WIN32_WINNT=0x0600 -c /home/Thad/rust/src/libuv/src/ine
t.c -o src/inet.o
gcc -I/home/Thad/rust/src/libuv/include -I/home/Thad/rust/src/libuv/include/uv-p
rivate -g --std=gnu89 -D_WIN32_WINNT=0x0600 -c /home/Thad/rust/src/libuv/src/uv-
common.c -o src/uv-common.o
ar rcs libuv.a /home/Thad/rust/src/libuv/src/win/async.o /home/Thad/rust/src/lib
uv/src/win/core.o /home/Thad/rust/src/libuv/src/win/dl.o /home/Thad/rust/src/lib
uv/src/win/error.o /home/Thad/rust/src/libuv/src/win/fs-event.o /home/Thad/rust/
src/libuv/src/win/fs.o /home/Thad/rust/src/libuv/src/win/getaddrinfo.o /home/Tha
d/rust/src/libuv/src/win/handle.o /home/Thad/rust/src/libuv/src/win/loop-watcher
.o /home/Thad/rust/src/libuv/src/win/pipe.o /home/Thad/rust/src/libuv/src/win/po
ll.o /home/Thad/rust/src/libuv/src/win/process-stdio.o /home/Thad/rust/src/libuv
/src/win/process.o /home/Thad/rust/src/libuv/src/win/req.o /home/Thad/rust/src/l
ibuv/src/win/signal.o /home/Thad/rust/src/libuv/src/win/stream.o /home/Thad/rust
/src/libuv/src/win/tcp.o /home/Thad/rust/src/libuv/src/win/thread.o /home/Thad/r
ust/src/libuv/src/win/threadpool.o /home/Thad/rust/src/libuv/src/win/timer.o /ho
me/Thad/rust/src/libuv/src/win/tty.o /home/Thad/rust/src/libuv/src/win/udp.o /ho
me/Thad/rust/src/libuv/src/win/util.o /home/Thad/rust/src/libuv/src/win/winapi.o
/home/Thad/rust/src/libuv/src/win/winsock.o src/fs-poll.o src/inet.o src/uv-com
mon.o
make[2]: Leaving directory /home/Thad/rust/rt/i686-w64-mingw32/libuv' make[1]: Leaving directory/home/Thad/rust/src/libuv'
link: rt/i686-w64-mingw32/rustrt.dll
rt/rustrt.mingw32.def:2: Warning: path components stripped from LIBRARY, 'rt/rus
trt'
cp: i686-w64-mingw32/stage0/bin/rustc/i686-w64-mingw32/bin/rustrt.dll
compile: rt/i686-w64-mingw32/arch/i386/morestack.o
link: rt/i686-w64-mingw32/arch/i386/libmorestack.a
cp: i686-w64-mingw32/stage0/bin/rustc/i686-w64-mingw32/bin/libmorestack.a
compile_and_link: i686-w64-mingw32/stage0/bin/rustc/i686-w64-mingw32/bin/core.dl
l
make: *** [i686-w64-mingw32/stage0/bin/rustc/i686-w64-mingw32/bin/core.dll] Erro
r 255

Thad@Thad-Windows ~/rust
$

@huonw
Copy link
Member

huonw commented Aug 19, 2013

Visiting for triage; I cannot test this, but there was a pull request that added support for x86_64-w64-mingw32.

In any case, @klutzy tested with ./configure --build-triple=i686-w64-mingw32 and said that there is no such build triple; so I'm closing this. (Reopen if I'm wrong, preferably with the exact steps to reproduce. :) )

@huonw huonw closed this as completed Aug 19, 2013
@thadguidry
Copy link
Contributor Author

No, you are correct, there is no such build of "i686-w64" ... the correct build would be "x86_64-w64". Closing this issue is fine. Thanks Huon !

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 20, 2020
…ebroto

Lint also in trait def for `wrong_self_convention`

Extends `wrong_self_convention` to lint also in trait definition.

By the way, I think the `wrong_pub_self_convention` [example](https://github.com/rust-lang/rust-clippy/blob/dd826b4626c00da53f76f00f02f03556803e9cdb/clippy_lints/src/methods/mod.rs#L197) is misleading.
On [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=32615ab3f6009e7e42cc3754be0ca17f), it fires `wrong_self_convention`, so the example (or the lint maybe?) needs to be reworked.
The difference with `wrong_self_convention` [example](https://github.com/rust-lang/rust-clippy/blob/dd826b4626c00da53f76f00f02f03556803e9cdb/clippy_lints/src/methods/mod.rs#L172) is mainly the `pub` keyword on the method `as_str`, but the lint doesn't use the function visibility as condition to choose which lint to fire (in fact it uses the visibility of the impl item).

fixes: rust-lang#6307

changelog: Lint `wrong_self_convention` lint in trait def also
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 15, 2021
Ensure `Copy` exception in trait definition for `wrong_self_conventio…

Add a test case to ensure `Copy` exception is preserved also in trait definition, when passing `self` by value.

Follow up of rust-lang#6316

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants