3rd party objects missing from nightly-2019-10-12

[jethrogb]

$ rustup toolchain add nightly-2019-10-11
$ rustup toolchain add nightly-2019-10-12
$ rustup target add --toolchain nightly-2019-10-11 x86_64-fortanix-unknown-sgx
$ rustup target add --toolchain nightly-2019-10-12 x86_64-fortanix-unknown-sgx
$ ls .rustup/toolchains/nightly-2019-10-11-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
.rustup/toolchains/nightly-2019-10-11-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
$ ls .rustup/toolchains/nightly-2019-10-12-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a
ls: cannot access '.rustup/toolchains/nightly-2019-10-12-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-fortanix-unknown-sgx/lib/libunwind.a': No such file or directory

[jethrogb]

x86_64-unknown-linux-musl is also affected

Checkout the size difference:

$ rustup target add --toolchain nightly-2019-10-12 x86_64-unknown-linux-musl
info: downloading component 'rust-std' for 'x86_64-unknown-linux-musl'
 16.2 MiB /  16.2 MiB (100 %)   3.6 MiB/s ETA:   0 s                
info: installing component 'rust-std' for 'x86_64-unknown-linux-musl'
$ rustup target add --toolchain nightly-2019-10-11 x86_64-unknown-linux-musl
info: downloading component 'rust-std' for 'x86_64-unknown-linux-musl'
172.9 MiB / 172.9 MiB (100 %)   3.8 MiB/s ETA:   0 s                
info: installing component 'rust-std' for 'x86_64-unknown-linux-musl'

Link error when trying to build a musl binary:

  = note: cc: error: crt1.o: No such file or directory
          cc: error: crti.o: No such file or directory
          cc: error: crtn.o: No such file or directory

[mati865]

I checked rust-std, rustc and rustc-dev components and libs mentioned above are totally gone.

@rustbot modify labels: +T-release +C-bug

[mati865]

Tier-1 windows-gnu toolchain is also broken:

  = note: gcc.exe: error: crt2.o: No such file or directory
          gcc.exe: error: rsbegin.o: No such file or directory
          gcc.exe: error: rsend.o: No such file or directory

[pietroalbini]

cc @rust-lang/release

[pietroalbini]

So @rust-lang/release, as the rustc-dev PR broke tons of tier 2 targets and even a tier 1 target, I'd say for now we should revert the change and then land it again once it's properly fixed and tested on most of the platforms we support.

I think the priority should be keeping nightly as usable as possible (thus reverting the PR), reducing the stdlib size is less important and can be done later.

[cuviper]

Checkout the size difference:

That was the intent of #64823, but I'm very sorry that I neglected these extra runtime objects. My focus is on linux-gnu targets, which don't ship those, so I didn't see the difference.

I'm glad you already have a fix PR!

[RalfJung]

Tier-1 windows-gnu toolchain is also broken:

Ah, this probably explains why Miri CI is failing on Windows with this change. (Though I think that's using windows-msvc?)

Executing the compiled Miri binary just fails without any stdout/stderr indicating why.

[pietroalbini]

We're reverting the PR that caused the regression in #65342.

[gnzlbg]

All libc musl build jobs are also failing, probably due to this.

[cuviper]

Revert #65342 landed 15 hours ago, so the next nightly should have the original full rust-std again. We'll retry the limited set later, with any 3rd party objects needed, but first I want to figure out how to sanity-check the dist package in CI for all targets so this doesn't regress.

There is a distcheck job, but only for x86_64-unknown-linux-gnu, which wasn't affected. On Discord we were talking about adding a simple "hello world" test as something quick for all targets.

[pietroalbini]

This should be fixed in the latest nightly.

[jethrogb]

Yup it is!