Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type option for the pretty printer is completely broken #6683

Closed
mstewartgallus opened this issue May 22, 2013 · 3 comments
Closed

The type option for the pretty printer is completely broken #6683

mstewartgallus opened this issue May 22, 2013 · 3 comments
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.

Comments

@mstewartgallus
Copy link
Contributor

The command rustc --pretty=typed file.rs crashes for even the simplest of files, the file:

fn main () { }
@msullivan
Copy link
Contributor

That test works for me...

@msullivan
Copy link
Contributor

Works on a bunch of other files I tried too. Now, it doesn't seem very useful, but it works, so. Closing.

@mstewartgallus
Copy link
Contributor Author

@msullivan it must have been fixed recently but are there tests that will prevent it from regressing again?

flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 11, 2021
… inside the rustc repo.

Do not check if clippy version matches rustc version when runnning tests inside the rustc repo.
This makes sure that upstream rustc maintainers do not have to deal with our test failing/mismatching versions
when the rustc version bump is happening.
cc rust-lang#6683
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 11, 2021
…stream, r=flip1995

tests: ignore check_that_clippy_has_the_same_major_version_as_rustc()inside the rustc repo

Do not check if clippy version matches rustc version when runnning tests inside the rustc repo.
This makes sure that upstream rustc maintainers do not have to deal with our test failing/mismatching versions
when the rustc version bump is happening.
cc rust-lang#6683

We already do the "don't run inside the rustc-repo" workaround for the dogfood test:
https://github.com/rust-lang/rust-clippy/blob/a507c27660d05f37307369d30bee9e82ce3a11e1/tests/dogfood.rs#L16

changelog: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics.
Projects
None yet
Development

No branches or pull requests

2 participants