-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICE on unused generic in struct #67375
Comments
A quick look on godbold gives that this ICE's in |
The illigal instruction happens when |
triage: P-high, removing nomination. |
@rustbot modify labels: E-needs-bisection |
I did a rough bisection with Godbolt and found this ICE was introduced in the Rust 1.17 release. Though this never worked (at least on stable); in previous versions there were various const-eval non-ICE errors. |
Okay, I ran
|
Requesting reprioritization. @rustbot modify labels: +I-prioritized |
Error: Label P-high can only be set by Rust team members Please let |
Hmm, rustbot isn't setting the label... I think I'm allowed to do that: Line 7 in 2e0edc0
|
well you need to re-"request to prioritise" it not re-prioritise it , so you should mark it as |
Oops, it's because I made a typo :) @rustbot modify labels: I-prioritize |
related to const generics, fixed by both This bug is expected, marking as |
Re-prioritizing as P-medium as discussed by the prioritization WG. |
…lcnr,estebank Fix missing diagnostic span for `impl Trait` with const generics, and add various tests for `min_const_generics` and `const_generics` Closes rust-lang#61410. Adds `min_const_generics` tests for: - rust-lang#73727 - rust-lang#72293 - rust-lang#67375 - rust-lang#75153 - rust-lang#71922 - rust-lang#69913 - rust-lang#67945 - rust-lang#69239 Adds `const_generics` tests for: - rust-lang#67375 - rust-lang#75153 - rust-lang#71922 - rust-lang#69913 - rust-lang#67945 - rust-lang#69239 (I only added separate `min_const_generics` and `const_generics` tests if they were handled differently by the two features.) We need to figure out how to deduplicate when `const_generics` is stabilised, but we can discuss that later. For now, we should be checking neither feature breaks, so require regression tests for both. I've given them identical names when I've added both, which should make it easier to spot them later. r? @lcnr
If this is fixed with a test, it can be closed, right? |
yup |
However it looks like this hasn't actually been fixed: it still ICEs unless you add |
@lcnr is that expected behavior? ^ |
It is expected to ICE without const generics, so we may want to keep this issue open until I do however feel like that won't be that useful as we won't work on fixing this until then. |
Originally posted by @varkor in #74878 (comment) |
Let's leave as open for now, though hopefully we're not far from stabilisation anyway, so we should be able to close this issue again soon. |
Triage: |
The following ICE's in stable, beta and nightly:
Backtrace:
Also I noted an
illigal instruction
in the output of how it was compiled. It says so at the verry verry end of this output:https://pastebin.com/Wd299cWN
or easier to see in this screenshot: http://prntscr.com/qc8252
The text was updated successfully, but these errors were encountered: