Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge libextra and the test suite of all calls directly into the runtime #6809

Closed
bstrie opened this issue May 29, 2013 · 3 comments
Closed
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@bstrie
Copy link
Contributor

bstrie commented May 29, 2013

A prerequisite for #3361.

Calls into the runtime look like rustrt::foo().

$ git grep rustrt -- src/libextra/ | wc -l
37

$ git grep rustrt -- src/test/ | wc -l
69
@msullivan
Copy link
Contributor

Current status

sully@anansi:~/src/rust2 [master]$ git grep rustrt -- src/libextra/ | wc -l
28
sully@anansi:~/src/rust2 [master]$ git grep rustrt -- src/test/ | wc -l
73

Going in the right direction in libextra, wrong direction in the test suites.

The uses in libextra are in dbg.rs (what is that for? is it still used?), flate.rs, rl.rs, and time.rs.

@msullivan
Copy link
Contributor

Related to #4812.

@alexcrichton
Copy link
Member

Turns out this wasn't a prereq for #3361 because I cheated and linked librustrt to libextra. This isn't in a bad situation at all today, and everything is statically linked as you would expect, so this is no longer an issue.

flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 8, 2021
Use binary-dep-depinfo to resolve UI test dependencies

Closes rust-lang#7343
Closes rust-lang#6809
Closes rust-lang#3643

changelog: none

r? `@flip1995`
cc `@Jarcho`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants