miri no longer builds after rust-lang/rust#69105
#69117
Assignees
Labels
P-medium
Medium priority
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rust-highfive
added
I-nominated
T-compiler
Merged
|
Triage meeting: Tagged as P-medium, appears to have PR. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Feb 13, 2020
miri: fix exact_div Turns out `exact_div` was relying on the broken behavior of `Rem` for `int_min % -1` that was fixed in rust-lang#69002. This PR fixes `exact_div`. Inside rustc, `exact_div` is only used in a single place where the divisor is always positive (in `ptr_offset_from`), so we cannot test the fix in rustc. The Miri test suite covers this through the `exact_div` intrinsic, though (and it is how I found out). One step to rust-lang#69117 (then we also need to address build failures introduced by rust-lang#68969) r? @oli-obk
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, this is your friendly neighborhood mergebot.
After merging PR #69105, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.
cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!
cc @Dylan-DPC, the PR reviewer, and nominating for compiler team prioritization.
The text was updated successfully, but these errors were encountered: