Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move keyword page makes no mention of async blocks #69298

Closed
That3Percent opened this issue Feb 19, 2020 · 2 comments · Fixed by #69477
Closed

Move keyword page makes no mention of async blocks #69298

That3Percent opened this issue Feb 19, 2020 · 2 comments · Fixed by #69477
Assignees
@rustbot
Labels
A-async-await Area: Async & Await A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority

Comments

@That3Percent
Copy link

That3Percent commented Feb 19, 2020 •
edited by rustbot
Loading

The move keyword page currently talks only about the use of move with closures. The move keyword is also valid before an async block. For example: async move { /*...*/ }. This page could be updated to include that usage.

This issue has been assigned to @Pulkit07 via this comment.
@jonas-schievink jonas-schievink added A-async-await Area: Async & Await C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Feb 19, 2020
@tmandry tmandry added AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. P-medium Medium priority E-needs-mentor labels Feb 25, 2020
@nikomatsakis
Copy link
Contributor

Mentoring instructions

Edit src/libstd/keyword_docs.rs and make the text talk about async blocks as well.

@nikomatsakis nikomatsakis added E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed E-needs-mentor labels Feb 25, 2020
@Pulkit07
Copy link
Contributor

@rustbot claim

@rustbot rustbot self-assigned this Feb 25, 2020
@Pulkit07 Pulkit07 mentioned this issue Feb 26, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 29, 2020
@Dylan-DPC
Rollup merge of rust-lang#69477 - Pulkit07:issue69298, r=cramertj
222aa62 
docs: add mention of async blocks in move keyword docs

Fixes rust-lang#69298
@bors bors closed this as completed in 299a0d5 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-async-await Area: Async & Await A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. C-enhancement Category: An issue proposing an enhancement or a PR with one. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add mention of async blocks in move keyword docs Pulkit07/rust
6 participants
@nikomatsakis @jonas-schievink @tmandry @Pulkit07 @rustbot @That3Percent