Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy-driver no longer builds after rust-lang/rust#71044 #71453

Closed
rust-highfive opened this issue Apr 23, 2020 · 0 comments · Fixed by #71468
Closed

clippy-driver no longer builds after rust-lang/rust#71044 #71453

rust-highfive opened this issue Apr 23, 2020 · 0 comments · Fixed by #71468
Assignees
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @flip1995

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #71044, I observed that the tool clippy-driver no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rust-clippy is needed to fix the fallout.

cc @ecstatic-morse, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@matthiaskrgr matthiaskrgr mentioned this issue Apr 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 26, 2020
@bors
Auto merge of rust-lang#71468 - matthiaskrgr:submodule_upd, r=Dylan-DPC
5794e77 
submodules: update clippy from 891e1a8 to d01a498

Changes:
````
`predecessors_for` will be removed soon
Rustup "Remove `BodyAndCache`"
span_lint_and_note now takes an Option<Span> for the note_span instead of just a span
Make lint also capture blocks and closures, adjust language to mention other mutex types
don't test the code in the lint docs
Switch to matching against full paths instead of just the last element of the path
Lint for holding locks across await points
fix crash on issue-69020-assoc-const-arith-overflow.rs
update stderr file
util/fetch_prs_between.sh: Add Markdown formatted Link
factor ifs into function, add differing mutex test
Update the changelog update documentation
Apply suggestions from PR review
update span_lint_and_help call to six args
test for mutex eq, add another test case
use if chain
cargo dev fmt
fix map import to rustc_middle
dev update_lints
fix internal clippy warnings
change visitor name to OppVisitor
use Visitor api to find Mutex::lock calls
add note about update-all-refs script, revert redundant pat to master
move closures to seperate fns, remove known problems
use span_lint_and_help, cargo dev fmt
creating suggestion
progress work on suggestion for auto fix
Implement unsafe_derive_deserialize lint
Update empty_enum.stderr
Formatting and naming
Formatting and naming
Cleanup: `node_id` -> `hir_id`
Fix issue rust-lang#2907.
Don't trigger toplevel_ref_arg for `for` loops
Cleanup: future_not_send: use `return_ty` method
Remove badge FIXME from Cargo.toml
Change note_span argument for span_lint_and_note.
Add an Option<Span> argument to span_lint_and_help.
Fixes internal lint warning in code base.
Implement collapsible_span_lint_calls lint.
````

Fixes rust-lang#71453

r? @Dylan-DPC
@bors bors closed this as completed in 3d514f4 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oli-obk oli-obk

@Manishearth Manishearth

@yaahc yaahc

@phansch phansch

@mcarton mcarton

@llogiq llogiq

@flip1995 flip1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

submodules: update clippy from 891e1a85 to d01a4981 matthiaskrgr/rust
8 participants
@oli-obk @Manishearth @yaahc @phansch @mcarton @llogiq @rust-highfive @flip1995