Errors reported in rustc_lint::levels::LintLevelsBuilder::push occurs multiple times
#73301
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
crlf0710
added
C-bug
|
E0453 is actually covered by tests, it's just that its description contains an outdated error message. If you search for "incompatible with previous forbid" you will find the tests. (I update the description of E0453 in #119388) |
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Dec 30, 2023
Rollup merge of rust-lang#119388 - Enselic:prevent-lint-triplication, r=cjgillot rustc_lint: Prevent triplication of various lints Prevent triplication of various lints. The triplication happens because we run the same lint three times (or less in some cases): * In `BuiltinCombinedPreExpansionLintPass` * In `BuiltinCombinedEarlyLintPass` * In `shallow_lint_levels_on()` Only run the lints one time by checking the `lint_added_lints` bool. Set your GitHub diff setting to ignore whitespaces changes when reviewing this PR, since I had to enclose a block inside an if. Closes rust-lang#73301 (I found this while exploring the code related to [this](rust-lang#119251 (comment)) comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems errors (validation failures) reported from
rustc_lint::levels::LintLevelsBuilder::pushwill occur multiple times. Examples areE0453(not covered by tests) andE0763(being added in #73300 , unit test reflecting this problem). I'm not sure what's the best way forward.The text was updated successfully, but these errors were encountered: