Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split up rustc_middle/mir/mod.rs #73723

Closed
oli-obk opened this issue Jun 25, 2020 · 1 comment · Fixed by #73776
Closed

split up rustc_middle/mir/mod.rs #73723

oli-obk opened this issue Jun 25, 2020 · 1 comment · Fixed by #73776
Assignees
@rustbot
Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jun 25, 2020 •
edited by rustbot
Loading

#73513 moved the file to over 3k LOC, but I didn't fix it there and instead just annotated the file so tidy ignores it. We should probably split the mir types into separate submodules by the way they are used in MIR. I think we can start by pulling out e.g. terminators and all their sub-types to a terminator submodule

This issue has been assigned to @aszenz via this comment.
@oli-obk oli-obk added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jun 25, 2020
@jonas-schievink jonas-schievink added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2020
@aszenz
Copy link
Contributor

aszenz commented Jun 26, 2020 •
edited
Loading

@rustbot claim
Will be interested in picking this up

@rustbot rustbot assigned rustbot and unassigned rustbot Jun 26, 2020
@aszenz aszenz mentioned this issue Jun 26, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 1, 2020
@Manishearth
Rollup merge of rust-lang#73776 - aszenz:refactor_mir_module, r=wesle…
978953e 
…ywiser

Move terminator to new module

Moves terminator types from `librustc_middle/mir/mod.rs` into submodule
Fixes rust-lang#73723
@bors bors closed this as completed in d6bee55 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustbot rustbot

Labels
A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move terminator to new module aszenz/rust
4 participants
@oli-obk @jonas-schievink @aszenz @rustbot