Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly-rustc docs no longer document private items #74511

Closed
SNCPlay42 opened this issue Jul 19, 2020 · 7 comments · Fixed by #74514
Closed

nightly-rustc docs no longer document private items #74511

SNCPlay42 opened this issue Jul 19, 2020 · 7 comments · Fixed by #74514

Comments

@SNCPlay42
Copy link
Contributor

SNCPlay42 commented Jul 19, 2020 •
edited
Loading

Compare 1.45.0 version, nightly version

  • The "This is an internal compiler API." warning has disappeared this was intentional
  • Items which are private, like borrow_check, have disappeared
@tesuji
Copy link
Contributor

tesuji commented Jul 19, 2020

The warnings is removed in #74351 .

@tesuji
Copy link
Contributor

tesuji commented Jul 19, 2020 •
edited
Loading

The borrow_check haven't never been public. Not sure if I made it disappeared.

cc @Mark-Simulacrum

@tesuji
Copy link
Contributor

tesuji commented Jul 19, 2020 •
edited
Loading

Also this page https://doc.rust-lang.org/nightly/nightly-rustc is 404 now.
Before it listed all the internal crates.

@Mark-Simulacrum
Copy link
Member

I don't see how your PR could've done that -- cc @jyn514 I think you recently had a PR touching document-private-items?

@jyn514
Copy link
Member

jyn514 commented Jul 19, 2020

The PR just changed some warnings around intra-doc-links, nothing to do with fn href. My suspicion since the index page is gone is that something changed in bootstrap.

@jyn514
Copy link
Member

jyn514 commented Jul 19, 2020 •
edited
Loading

I take it back, I did modify href in https://github.com/rust-lang/rust/pull/72771/files#diff-2e4303616596f7b39dfebcbabb8a49b0R471. That was a few weeks ago now and should have documented strictly more items, though.

@ollie27
Copy link
Member

ollie27 commented Jul 19, 2020

This is the issue I pointed out in the second part of #71670 (comment). I clearly didn't explain the issue well enough.

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jul 19, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 19, 2020
@Manishearth
Rollup merge of rust-lang#74514 - Mark-Simulacrum:nightly-rustc-docs,…
247ee15 
… r=ollie27

Do not clobber RUSTDOCFLAGS

We were setting these in both Builder::cargo and here, which ended up only setting the first of the two.

Fixes rust-lang#74511
@bors bors closed this as completed in 3981386 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not clobber RUSTDOCFLAGS Mark-Simulacrum/rust
5 participants
@Mark-Simulacrum @SNCPlay42 @ollie27 @tesuji @jyn514