-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch rustdoc from lexer::StringReader
to rustc_lexer
#75619
Labels
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
matklad
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Aug 17, 2020
sgtm |
I'm fine with it as well. :) |
BTW, is there some chat room for rustdoc team on zulip on discord? I'd like to ask some questions :) |
There is one on discord (simply called "rustdoc"). |
It's linked at https://www.rust-lang.org/governance/teams/dev-tools#rustdoc (which is I agree pretty hard to find). Also the text there is wrong and mentions docs.rs, we should probably fix that. |
jyn514
added a commit
to jyn514/team
that referenced
this issue
Sep 1, 2020
Left over from rust-lang#182, I noticed it in rust-lang/rust#75619 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #75528, we would like to tweak the structure of the tokens rustc uses. One of the components which heavily depends on the current structure is
rustdoc
(html
andcheck_code_block_syntax
module uselexer::StringReader
).I think, for this issue and in general, it makes sense to switch
rustdoc
over torustc_lexer
, which produces lower-level guaranteed lossless tokens, which look like a better fit for the task of syntax highlighting.I plan to do this refactor myself, but I want to check with @rust-lang/rustdoc if this is a good idea.
EDIT: cc #63284
The text was updated successfully, but these errors were encountered: