Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for rust-lldb python wrappers #76288

Open
pnkfelix opened this issue Sep 3, 2020 · 1 comment
Open

Add regression tests for rust-lldb python wrappers #76288

pnkfelix opened this issue Sep 3, 2020 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Sep 3, 2020

I am posting this issue mostly as a reminder that we should investigate why our current test suite didn't seem to catch the breakage from #76006 on any of our CI platforms

@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 3, 2020
@ehuss
Copy link
Contributor

ehuss commented Sep 3, 2020

Looking through the history, it doesn't appear that there were ever any tests added for the python wrappers.

However, I did notice something concerning (unrelated to the above issue). All of the // rust-lldb tests are no longer being run with lldb. These are tests that are intended to run with the rust-variant of lldb, but that has been removed (#72058). The following tests are affected:

I'm not sure if any of these tests specifically need to be a "rust" variant of lldb, or just need a relatively new version of lldb. The rust-variant requirement was added in #54764.

I tried running some of the tests with my system lldb, and the format of the output has changed, so they seem to fail.

@Enselic Enselic changed the title Why didnt our test suite catch lldb breakage? Add regression tests for rust-lldb python wrappers Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants