-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run debuginfo tests against rust-enabled lldb, when possible #54764
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ |
📌 Commit dd4a2e1056c1a3fa77bdb51b3c63311dfefcaced has been approved by |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Now with tidy tweaks. Line length limits have to be ignored because the debugger tests have to fit on one line. |
@bors: r+ delegate+ |
✌️ @tromey can now approve this pull request |
📌 Commit 8da08c0 has been approved by |
Run debuginfo tests against rust-enabled lldb, when possible If the rust-enabled lldb was built, then use it when running the debuginfo tests. Updating the lldb submodule was necessary as this needed a way to differentiate the rust-enabled lldb, so I added a line to the --version output. This adds compiletest commands to differentiate between the rust-enabled and non-rust-enabled lldb, as is already done for gdb. A new "rust-lldb" header directive is also added, but not used in this patch; I plan to use it in rust-lang#54004. This updates all the tests.
⌛ Testing commit 8da08c0 with merge 14c45a10d3faac0b67711b55d17074e3c315d8b5... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
⌛ Testing commit 8da08c0 with merge 8b6aed69da6a2434f0f14687b04c98e3c1163294... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
If the rust-enabled lldb was built, then use it when running the debuginfo tests. Updating the lldb submodule was necessary as this needed a way to differentiate the rust-enabled lldb, so I added a line to the --version output. This adds compiletest commands to differentiate between the rust-enabled and non-rust-enabled lldb, as is already done for gdb. A new "rust-lldb" header directive is also added, but not used in this patch; I plan to use it in rust-lang#54004. This updates all the tests.
Some typos in the "lldbg" case, which apparently did not get tested here. This will be easier once I fix #54721. |
@bors: r+ |
📌 Commit ac33b2e has been approved by |
⌛ Testing commit ac33b2e with merge cc738a506399248340c3b0abb8c69eaa3d25c849... |
💔 Test failed - status-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
I don't understand what went wrong there. I see this at the end, but as far as I know this isn't something my patch would influence:
I couldn't find any ordinary test failure. |
Also if I click on the Travis link it looks like the Travis build is actually done. |
@bors retry |
Run debuginfo tests against rust-enabled lldb, when possible If the rust-enabled lldb was built, then use it when running the debuginfo tests. Updating the lldb submodule was necessary as this needed a way to differentiate the rust-enabled lldb, so I added a line to the --version output. This adds compiletest commands to differentiate between the rust-enabled and non-rust-enabled lldb, as is already done for gdb. A new "rust-lldb" header directive is also added, but not used in this patch; I plan to use it in #54004. This updates all the tests.
☀️ Test successful - status-appveyor, status-travis |
If the rust-enabled lldb was built, then use it when running the
debuginfo tests. Updating the lldb submodule was necessary as this
needed a way to differentiate the rust-enabled lldb, so I added a line
to the --version output.
This adds compiletest commands to differentiate between the
rust-enabled and non-rust-enabled lldb, as is already done for gdb. A
new "rust-lldb" header directive is also added, but not used in this
patch; I plan to use it in #54004.
This updates all the tests.