Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for const_assume feature #76972

Closed
1 of 3 tasks
tesuji opened this issue Sep 20, 2020 · 2 comments · Fixed by #119583
Closed
1 of 3 tasks

Tracking Issue for const_assume feature #76972

tesuji opened this issue Sep 20, 2020 · 2 comments · Fixed by #119583
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-perma-unstable Status: The feature will stay unstable indefinitely. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Sep 20, 2020 •
edited
Loading

The feature gate for the issue is #![feature(const_assume)].
It makes core::intrinsics::assume usable in const contexts.

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

Implementation history
@tesuji tesuji added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Sep 20, 2020
@rustbot rustbot added A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Sep 20, 2020
@joshtriplett joshtriplett added the S-tracking-perma-unstable Status: The feature will stay unstable indefinitely. label Jul 20, 2022
@AngelicosPhosphoros
Copy link
Contributor

@tesuji Do you want to stabilize the feature?
I was asked to use assume in const context here: #119452

@AngelicosPhosphoros AngelicosPhosphoros mentioned this issue Jan 3, 2024
Merged
@Noratrieb
Copy link
Member

WG-const-eval has confirmed that this is fine: #119452 (comment)

Feel free to send in a PR flipping the stability attribute. It's an unstable intrinsic so we aren't really committing to anything.

AngelicosPhosphoros added a commit to AngelicosPhosphoros/rust that referenced this issue Jan 4, 2024
@AngelicosPhosphoros
Make intrinsics::assume const stable
59c76fb 
Closes rust-lang#76972
Blocks rust-lang#119452

Approved in rust-lang#119452 (comment)
@AngelicosPhosphoros AngelicosPhosphoros mentioned this issue Jan 4, 2024
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this issue Jan 5, 2024
@compiler-errors
Rollup merge of rust-lang#119583 - AngelicosPhosphoros:const_assume, …
8bea1df 
…r=RalfJung

Make `intrinsics::assume` const stable

Closes rust-lang#76972
Blocks rust-lang#119452

Approved in rust-lang#119452 (comment)

r? `@RalfJung`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 5, 2024
@rust-timer
Unrolled build for rust-lang#119583
ca507c0 
Rollup merge of rust-lang#119583 - AngelicosPhosphoros:const_assume, r=RalfJung

Make `intrinsics::assume` const stable

Closes rust-lang#76972
Blocks rust-lang#119452

Approved in rust-lang#119452 (comment)

r? `@RalfJung`
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jan 6, 2024
@compiler-errors
Rollup merge of #119583 - AngelicosPhosphoros:const_assume, r=RalfJung
a397104 
Make `intrinsics::assume` const stable

Closes rust-lang/rust#76972
Blocks rust-lang/rust#119452

Approved in rust-lang/rust#119452 (comment)

r? `@RalfJung`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC S-tracking-perma-unstable Status: The feature will stay unstable indefinitely. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make intrinsics::assume const stable AngelicosPhosphoros/rust
5 participants
@joshtriplett @AngelicosPhosphoros @tesuji @rustbot @Noratrieb