Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustdoc closes sidebar when window is resized #77942

Closed
Kestrer opened this issue Oct 14, 2020 · 4 comments · Fixed by #78013
Closed

Rustdoc closes sidebar when window is resized #77942

Kestrer opened this issue Oct 14, 2020 · 4 comments · Fixed by #78013
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Kestrer
Copy link
Contributor

Kestrer commented Oct 14, 2020

On a small viewport where the sidebar is hidden by default, if the sidebar is opened and then the window is resized the sidebar closes.

This makes rustdoc pages practically unusable on Android Firefox as scrolling down hides the top bar and resizes the window.
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 14, 2020
@jyn514 jyn514 added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Oct 15, 2020
@GuillaumeGomez
Copy link
Member

I don't see how you can resize a browser on a phone. Do you have a video of this behavior by any chance? I have to admit that I'm a bit lost here...

@tesuji
Copy link
Contributor

tesuji commented Oct 15, 2020

Do they mean zoom instead ?

@Kestrer
Copy link
Contributor Author

Kestrer commented Oct 15, 2020

Here's an image of the problem:

rustdoc

@GuillaumeGomez
Copy link
Member

Ok I see now. Thanks! I'll fix it in the next days.

@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 16, 2020
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 16, 2020
@GuillaumeGomez
Rollup merge of rust-lang#78013 - GuillaumeGomez:fix-sidebar-scroll-m…
0936414 
…obile-devices, r=jyn514

Fix sidebar scroll on mobile devices

Fixes rust-lang#77942.

The issue was coming from the appearance/disappearance of the "wrapper" on the mobile devices web browsers, which triggers the "resize" event, calling the `hideSidebar` function is the JS code.

r? @jyn514
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 16, 2020
@JohnTitor
Rollup merge of rust-lang#78013 - GuillaumeGomez:fix-sidebar-scroll-m…
40160a1 
…obile-devices, r=jyn514

Fix sidebar scroll on mobile devices

Fixes rust-lang#77942.

The issue was coming from the appearance/disappearance of the "wrapper" on the mobile devices web browsers, which triggers the "resize" event, calling the `hideSidebar` function is the JS code.

r? @jyn514
@bors bors closed this as completed in 001fcd9 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sidebar scroll on mobile devices GuillaumeGomez/rust
5 participants
@jonas-schievink @GuillaumeGomez @tesuji @jyn514 @Kestrer