Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nightly-rustc docs don't include rustdoc in the index #80307

Closed
jyn514 opened this issue Dec 22, 2020 · 1 comment · Fixed by #80316
Closed

nightly-rustc docs don't include rustdoc in the index #80307

jyn514 opened this issue Dec 22, 2020 · 1 comment · Fixed by #80316
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 22, 2020

https://doc.rust-lang.org/nightly/nightly-rustc/ doesn't have a link to https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc/.

Meta

HEAD is currently at 353f3a3.

This is generated with --enable-index-page:

rust/src/bootstrap/doc.rs

Line 528 in 353f3a3

cargo.rustdocflag("--enable-index-page");

So this is either a bug in rustdoc or bootstrap. Maybe rustdoc needs to be added to

rust/src/bootstrap/doc.rs

Line 541 in 353f3a3

for root_crate in &["rustc_driver", "rustc_codegen_llvm", "rustc_codegen_ssa"] {
?
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 22, 2020
@ehuss ehuss mentioned this issue Dec 23, 2020
Merged
@ehuss
Copy link
Contributor

ehuss commented Dec 23, 2020

Sorry, I neglected to include the flag for both invocations. Posted #80316 with a fix.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Dec 23, 2020
@GuillaumeGomez
Rollup merge of rust-lang#80316 - ehuss:rustdoc-index, r=Mark-Simulacrum
f21c845 
Include rustdoc in the compiler docs index.

This should help ensure that the index page at https://doc.rust-lang.org/nightly/nightly-rustc/ includes a link to the rustdoc docs as well.

Fixes rust-lang#80307
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 23, 2020
@Dylan-DPC
Rollup merge of rust-lang#80316 - ehuss:rustdoc-index, r=Mark-Simulacrum
59873e7 
Include rustdoc in the compiler docs index.

This should help ensure that the index page at https://doc.rust-lang.org/nightly/nightly-rustc/ includes a link to the rustdoc docs as well.

Fixes rust-lang#80307
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 24, 2020
@Dylan-DPC
Rollup merge of rust-lang#80316 - ehuss:rustdoc-index, r=Mark-Simulacrum
ffda29c 
Include rustdoc in the compiler docs index.

This should help ensure that the index page at https://doc.rust-lang.org/nightly/nightly-rustc/ includes a link to the rustdoc docs as well.

Fixes rust-lang#80307
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 24, 2020
@Dylan-DPC
Rollup merge of rust-lang#80316 - ehuss:rustdoc-index, r=Mark-Simulacrum
77052ad 
Include rustdoc in the compiler docs index.

This should help ensure that the index page at https://doc.rust-lang.org/nightly/nightly-rustc/ includes a link to the rustdoc docs as well.

Fixes rust-lang#80307
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 24, 2020
@Dylan-DPC
Rollup merge of rust-lang#80316 - ehuss:rustdoc-index, r=Mark-Simulacrum
f4d9a3d 
Include rustdoc in the compiler docs index.

This should help ensure that the index page at https://doc.rust-lang.org/nightly/nightly-rustc/ includes a link to the rustdoc docs as well.

Fixes rust-lang#80307
@bors bors closed this as completed in 1f5beec Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include rustdoc in the compiler docs index. ehuss/rust
2 participants
@ehuss @jyn514