[rustdoc] Remove query component from URL by pressing ESC #81330
Labels
A-rustdoc-ui
Area: Rustdoc UI (generated HTML)
C-feature-request
Category: A feature request, i.e: not implemented / a PR.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
rustbot
added
C-feature-request
|
@GuillaumeGomez, could you share some thoughts about this feature request? |
|
I think it's a good idea. Gonna take a look at how to do it. |
Merged
|
Can we reopen this issue ? |
|
Oh I see, my bad. Reopening! |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Feb 22, 2021
…n-esc, r=Nemo157 Remove query parameters when skipping search results Fixes rust-lang#81330. This PR changes the following: when pressing ESC and that no other "action" was performed (understand: no closing the search result, or hiding a menu or something along the line), then we discard the URL query parameters (the `?whatever=dsjfs`). What do you think about this change `@rust-lang/rustdoc` ? EDIT: finally we're simply removing the query parameter when we're skipping the search results. r? `@Nemo157`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this issue
Feb 23, 2021
…n-esc, r=Nemo157 Remove query parameters when skipping search results Fixes rust-lang#81330. This PR changes the following: when pressing ESC and that no other "action" was performed (understand: no closing the search result, or hiding a menu or something along the line), then we discard the URL query parameters (the `?whatever=dsjfs`). What do you think about this change ``@rust-lang/rustdoc`` ? EDIT: finally we're simply removing the query parameter when we're skipping the search results. r? ``@Nemo157``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mdbook v4.6+ has a feature that pressing ESC removes query components from URLs (for example
?highlight=...).The feature was implemented in rust-lang/mdBook#1427.
It would be nice if rustdoc offers the same kind of that feature.
This is, for example, an URL that contains query components in rustdoc: https://doc.rust-lang.org/nightly/std/time/struct.Duration.html?search=asdfasdf.
What's the benefit of this feature?
When users share URLs to an API, they don't have to remove the query manually.
The text was updated successfully, but these errors were encountered: