Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error code linter should detect when an error code isn't checked in its explanation #83268

Closed
GuillaumeGomez opened this issue Mar 18, 2021 · 0 comments · Fixed by #83451
Closed

Error code linter should detect when an error code isn't checked in its explanation #83268

GuillaumeGomez opened this issue Mar 18, 2021 · 0 comments · Fixed by #83451
Assignees
@GuillaumeGomez
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@GuillaumeGomez
Copy link
Member

From this comment.
@GuillaumeGomez GuillaumeGomez added the A-diagnostics Area: Messages for errors, warnings, and lints label Mar 18, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 18, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 24, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 4, 2021
@GuillaumeGomez
Rollup merge of rust-lang#83451 - GuillaumeGomez:fix-error-code-tidy-…
4a50ec0 
…check, r=Mark-Simulacrum

Fix error codes check run and ensure it will not go unnoticed again

Fixes rust-lang#83268.

The error codes explanations were not checked anymore. I fixed this issue and also added variables to ensure that this won't happen again (at least not silently).
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 4, 2021
@GuillaumeGomez
Rollup merge of rust-lang#83451 - GuillaumeGomez:fix-error-code-tidy-…
54b5f02 
…check, r=Mark-Simulacrum

Fix error codes check run and ensure it will not go unnoticed again

Fixes rust-lang#83268.

The error codes explanations were not checked anymore. I fixed this issue and also added variables to ensure that this won't happen again (at least not silently).
@bors bors closed this as completed in 5b0ab79 Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error codes check run and ensure it will not go unnoticed again GuillaumeGomez/rust
1 participant
@GuillaumeGomez