Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc.rust-lang.org/nightly/nightly-rustc is down #83914

Closed
camelid opened this issue Apr 6, 2021 · 9 comments · Fixed by #83955
Closed

doc.rust-lang.org/nightly/nightly-rustc is down #83914

camelid opened this issue Apr 6, 2021 · 9 comments · Fixed by #83955
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Apr 6, 2021

I think it was working yesterday, but https://doc.rust-lang.org/nightly/nightly-rustc/ is giving a "Not Found" response for me. https://doc.rust-lang.org/beta/nightly-rustc/ works fine, however.

@camelid camelid added T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. C-bug Category: This is a bug. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Apr 6, 2021
@Mark-Simulacrum
Copy link
Member

Hm, I wonder if this is a similar bug to the one fixed due to link check failure during the bootstrap bump.

@camelid
Copy link
Member Author

camelid commented Apr 6, 2021

FYI, /nightly/std works fine—it seems to just be /nightly/nightly-rustc.

@Mark-Simulacrum
Copy link
Member

Yeah, almost certainly the bootstrap bump. cc @ehuss (just a heads up, I plan to submit a patch soon, though haven't written it yet)

@Mark-Simulacrum
Copy link
Member

My guess without too much investigation is that the symlink_dir_force which intends to share the compiler-doc directory between rustdoc and rustc docs is ending up clobbered. I likely won't get around to a fix tonight but may be able to do so tomorrow, we'll see how much time I have.

@ehuss
Copy link
Contributor

ehuss commented Apr 6, 2021

I'm also happy to revert the change on beta, if you want, so there isn't a rush to fix things.

@Mark-Simulacrum
Copy link
Member

Yeah, I think we should do that - there's enough stuff broken in rustbuild that's not really of the too unusual kind (well, really just two cases, but they seem fairly typical). I'd rather we drop it from beta and either pursue resource-suffix as suggested by @jyn514 or at least tackle the bugs in rustbuild on a less urgent timescale before relanding. (Ideally we should figure out what people should do; rustbuild's approach to just building twice seems pretty... suboptimal; I imagine that the fix for this newly found bug will end up similar if I do it quickly).

@ehuss
Copy link
Contributor

ehuss commented Apr 6, 2021

OK, I have posted rust-lang/cargo#9332. I'll push through the changes, though it may take at least a few days to get beta updated and then bump the version.

@Mark-Simulacrum
Copy link
Member

Yeah. I think I'm not sure there's as easy a fix in this case (unlike the simple add of a double core build), as the clobbering occurs over two different steps I believe. So I think we'll wait for that patch to land and bump beta. (We could also temporarily remove, say, rustdoc or rustc docs - but that doesn't seem like a real benefit).

bors added a commit to rust-lang/cargo that referenced this issue Apr 6, 2021
beta: revert #8640 - rustdoc versioning checks

#8640 has been causing some problems with rustbuild (see rust-lang/rust#83914 and rust-lang/rust#83530 (comment)).  In order to give more time to figure out a solution, this reverts the change on beta.  Will need to take some time to figure out what to do on master.

Also cherry picked the following to get tests passing:
* #9316 — Fix semver docs for 1.51.
* #9307 — tests: Tolerate "exit status" in error messages
@bors bors closed this as completed in c53d2d4 Apr 7, 2021
@camelid
Copy link
Member Author

camelid commented Apr 8, 2021

Thanks for the speedy fix! The docs are back online now (because it's a bit after midnight UTC). I'm glad they're back :)

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants