Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miri no longer builds after rust-lang/rust#84217 #84240

Closed
rust-highfive opened this issue Apr 16, 2021 · 1 comment · Fixed by #84249
Closed

miri no longer builds after rust-lang/rust#84217 #84240

rust-highfive opened this issue Apr 16, 2021 · 1 comment · Fixed by #84249
Assignees
@eddyb @RalfJung @oli-obk
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #84217, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @crlf0710, do you think you would have time to do the follow-up work?
If so, that would be great!
@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Apr 16, 2021
@crlf0710 crlf0710 mentioned this issue Apr 16, 2021
Merged
@crlf0710
Copy link
Member

rust-lang/miri#1777

bors added a commit to rust-lang/miri that referenced this issue Apr 16, 2021
@bors
Auto merge of #1777 - crlf0710:fix_compilation, r=RalfJung
a86eab3 
Remove `main_fn.rs` test.

Fixes build error caused by rust-lang/rust#84240 .
@crlf0710 crlf0710 mentioned this issue Apr 16, 2021
Merged
@bors bors closed this as completed in b0c818c Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eddyb eddyb

@RalfJung RalfJung

@oli-obk oli-obk

Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update miri. crlf0710/rust
5 participants
@eddyb @RalfJung @oli-obk @crlf0710 @rust-highfive