Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustdoc-gui test for checking new toggles #84422

Closed
GuillaumeGomez opened this issue Apr 22, 2021 · 0 comments · Fixed by #94155
Closed

Add rustdoc-gui test for checking new toggles #84422

GuillaumeGomez opened this issue Apr 22, 2021 · 0 comments · Fixed by #94155
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

This include testing #84321 as well.
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Apr 22, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 26, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 27, 2021
@bors
Auto merge of rust-lang#84552 - GuillaumeGomez:open-impl-blocks-by-de…
6eb956f 
…fault, r=jsha

Open impl blocks by default

Fixes rust-lang#84558.
Part of rust-lang#84422.

As you can see on https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/context/struct.TyCtxt.html, impl blocks are currently not open by default whereas they should.

I also realized that a test was outdated so I removed it and opened rust-lang#84550 because it seems like the rustdoc-gui test suite isn't run on CI...

cc `@jyn514`
r? `@jsha`
@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 19, 2022
Merged
@bors bors closed this as completed in 7dcbe69 Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend toggle GUI test a bit GuillaumeGomez/rust
2 participants
@Manishearth @GuillaumeGomez