Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for std::io::Seek::rewind() #85149

Closed
3 tasks done
ijackson opened this issue May 10, 2021 · 5 comments · Fixed by #86794
Closed
3 tasks done

Tracking Issue for std::io::Seek::rewind() #85149

ijackson opened this issue May 10, 2021 · 5 comments · Fixed by #86794
Assignees
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@ijackson
Copy link
Contributor

ijackson commented May 10, 2021

Feature gate: #![feature(seek_rewind)]

This is a tracking issue for the convenience method std::io::Seek::rewind().

Public API

pub trait Seek {
    /// This is a convenience method, equivalent to `seek(SeekFrom::Start(0))`.
    fn rewind(&mut self) -> Result<()>;
}

Steps / History

Unresolved Questions

  • None yet.
@ijackson ijackson added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 10, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jun 17, 2021

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Jun 17, 2021

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jun 17, 2021
@rfcbot
Copy link

rfcbot commented Jun 21, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Jun 21, 2021
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Jul 1, 2021
@rfcbot
Copy link

rfcbot commented Jul 1, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@bors bors closed this as completed in 2bc7d4d Jul 5, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jul 8, 2021
@inquisitivecrystal inquisitivecrystal self-assigned this Aug 28, 2021
@poliorcetics
Copy link
Contributor

poliorcetics commented Dec 12, 2022

I missed it completely in nigthlies sadly, else I would have proposed it returns the u64 of the old offset, because currently it cannot replace let old_offset = buf.seek(SeekFrom::Start(0))?;, only the form without assignement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants