Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reselecting the search field breaks the arrow key navigation 🐛 #85467

Closed
dns2utf8 opened this issue May 19, 2021 · 0 comments · Fixed by #85506
Closed

Reselecting the search field breaks the arrow key navigation 🐛 #85467

dns2utf8 opened this issue May 19, 2021 · 0 comments · Fixed by #85506
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@dns2utf8
Copy link
Contributor

Hi @jsha & @GuillaumeGomez

With the latest nightly, generate some documentation and search for something

I expected to see this happen: Select the first entry again

Instead, this happened: Nothing

Cheers
Stefan

Meta

This is a follow up to #84462

rustc --version --verbose:

rustc 1.54.0-nightly (4e3e6db01 2021-05-18)
@dns2utf8 dns2utf8 added the C-bug Category: This is a bug. label May 19, 2021
@GuillaumeGomez GuillaumeGomez added A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 19, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue May 20, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 21, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85506 - GuillaumeGomez:reset-focusedByTab, …
82376bb 
…r=jsha

Reset "focusedByTab" field when doing another search

Fixes rust-lang#85467.

The problem was simply that we forget to reset the `focusedByTab` field, which was still referring to removed DOM elements.

r? `@jsha`
@bors bors closed this as completed in 51a99eb May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset "focusedByTab" field when doing another search GuillaumeGomez/rust
2 participants
@dns2utf8 @GuillaumeGomez