Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate primitive/keyword search result extra info into DOM instead of CSS #85569

Closed
GuillaumeGomez opened this issue May 21, 2021 · 0 comments · Fixed by #85631
Closed

Generate primitive/keyword search result extra info into DOM instead of CSS #85569

GuillaumeGomez opened this issue May 21, 2021 · 0 comments · Fixed by #85631
Assignees
@GuillaumeGomez
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

As discussed in #85568, once it's merged (it adds a test so it'll need to be updated), I'll remove this from the CSS and it will be generated into the DOM directly.
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-rustdoc-js Area: Rustdoc's JS front-end labels May 21, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this May 21, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue May 24, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 25, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85631 - GuillaumeGomez:move-keywrod-primiti…
2596413 
…ve-css-dom, r=jsha

Move keyword primitive css dom

Fixes rust-lang#85569.

r? `@jsha`
@bors bors closed this as completed in 0f3c98a May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move keyword primitive css dom GuillaumeGomez/rust
1 participant
@GuillaumeGomez