Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Replace all remaining uses of Type::def_id_no_primitives() with Type::def_id() #90187

Closed
camelid opened this issue Oct 22, 2021 · 2 comments · Fixed by #92711
Closed

rustdoc: Replace all remaining uses of Type::def_id_no_primitives() with Type::def_id() #90187

camelid opened this issue Oct 22, 2021 · 2 comments · Fixed by #92711
Assignees
@mfrw
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Oct 22, 2021 •
edited
Loading

Steps

  1. Pass &Cache where it will be needed for def_id().
  2. Replace all uses of def_id_no_primitives() with def_id().
  3. Remove def_id_no_primitives() and simplify Type::inner_def_id().
@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Oct 22, 2021
@jyn514
Copy link
Member

jyn514 commented Oct 28, 2021

This is no longer blocked :)

@jyn514 jyn514 added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Oct 28, 2021
@mfrw
Copy link
Contributor

mfrw commented Oct 28, 2021

@rustbot claim

@mfrw mfrw mentioned this issue Oct 28, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90385 - mfrw:mfrw/librustdoc, r=GuillaumeGomez
6831829 
rustdoc: use Type::def_id() instead of Type::def_id_no_primitives()

For: rust-lang#90187

r? `@jyn514`
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 13, 2021
@bors
Auto merge of rust-lang#90385 - mfrw:mfrw/librustdoc, r=GuillaumeGomez
b416e38 
rustdoc: use Type::def_id() instead of Type::def_id_no_primitives()

For: rust-lang#90187

r? `@jyn514`
@mfrw mfrw mentioned this issue Dec 7, 2021
Closed
@zredb zredb mentioned this issue Dec 29, 2021
Closed
@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 9, 2022
Closed
@camelid camelid mentioned this issue Jan 28, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 30, 2022
@bors
Auto merge of rust-lang#92711 - zredb:issue-90187-fix, r=notriddle
08df8b8 
rustdoc: Remove `def_id_no_primitives`

Fixes rust-lang#90187.
@bors bors closed this as completed in ff88b59 Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfrw mfrw

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Remove def_id_no_primitives
Replace all def_id_no_primitives with def_id
issue-90187-fix
3 participants
@mfrw @jyn514 @camelid