Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logical lint pass for if( foo ) ... else if ( foo ) ... patterns #9288

Closed
kud1ing opened this issue Sep 18, 2013 · 1 comment
Closed

Add a logical lint pass for if( foo ) ... else if ( foo ) ... patterns #9288

kud1ing opened this issue Sep 18, 2013 · 1 comment

Comments

@kud1ing
Copy link

kud1ing commented Sep 18, 2013

This bug seems to present in the real world: http://www.viva64.com/en/examples/v517/
@kud1ing
Copy link
Author

kud1ing commented Sep 18, 2013

Let's discuss first

@kud1ing kud1ing closed this as completed Sep 18, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2022
@bors
Auto merge of rust-lang#9288 - lukaslueg:partialeqnone, r=Jarcho
3af9072 
Add partialeq_to_none lint

Initial implementation of rust-lang#9275, adding lint `partialeq_to_none`. This is my first time working on `clippy`, so please review carefully.

I'm unsure especially about the `Sugg`, as it covers the entire `BinOp`, instead of just covering one of the sides and the operator (see the multi-line example). I was unsure if pinpointing the suggestion wouldn't be brittle...

changelog: [`PARTIALEQ_TO_NONE`]: Initial commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kud1ing