Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[abi = "foo"] attributes from codebase. #9483

Closed
luqmana opened this issue Sep 25, 2013 · 2 comments · Fixed by #9606
Closed

Remove #[abi = "foo"] attributes from codebase. #9483

luqmana opened this issue Sep 25, 2013 · 2 comments · Fixed by #9606
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@luqmana
Copy link
Member

luqmana commented Sep 25, 2013

They no longer play any role in determining abi choice and just end up confusing people. If necessary they should just be replaced with the (relatively) new syntax: extern "foo" { ... }.
@wakandan
Copy link

I found quite a number of places where this bit happens. What tests should I run to make sure what I changed is working?

@wakandan
Copy link

above is the new commit I made

@steveklabnik steveklabnik mentioned this issue Sep 29, 2013
Merged
bors added a commit that referenced this issue Oct 14, 2013
@bors
auto merge of #9606 : steveklabnik/rust/abi_removal, r=alexcrichton
c8e77d5 
They've been replaced by putting the name on the extern block.

  #[abi = "foo"]

goes to

  extern "foo" { }

Closes #9483.
@bors bors closed this as completed in 16fc6a6 Oct 14, 2013
djkoloski pushed a commit to djkoloski/rust that referenced this issue Sep 21, 2022
@bors
Auto merge of rust-lang#9483 - c410-f3r:arith, r=Jarcho
5c3c6a2 
[arithmetic-side-effects] Finish non-overflowing ops

Extends rust-lang/rust-clippy#9474 to also take into consideration "raw" binary operations. For example, `let a = b / 2` and `let a = 1 * b` won't trigger the lint.

changelog: [arithmetic-side-effects] Finish non-overflowing ops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused abi attributes. steveklabnik/rust
2 participants
@luqmana @wakandan