Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] Duplicated errors #96211

Open
marmeladema opened this issue Apr 19, 2022 · 2 comments
Open

[NLL] Duplicated errors #96211

marmeladema opened this issue Apr 19, 2022 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@marmeladema
Copy link
Contributor

marmeladema commented Apr 19, 2022 •
edited by jackh726
Loading

A couple different related issues here.

In tests like src/test/ui/regions/region-lifetime-bounds-on-fns-where-clause.rs, the errors for mismatched types are actually duplicates (exactly the same error on the same line for the same span and the same notes.

Other similar tests:

In src/test/ui/rfc1623.rs, the errors are very similar, but not exactly duplicates.

@rustbot label +A-NLL +NLL-diagnostics
@marmeladema marmeladema added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2022
@rustbot rustbot added A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal labels Apr 19, 2022
@marmeladema marmeladema mentioned this issue Apr 19, 2022
Merged
@marmeladema
Copy link
Contributor Author

Actually, maybe it's a duplicate of #95686 ?

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 24, 2022
@matthiaskrgr
Rollup merge of rust-lang#96212 - marmeladema:nll-revisions-regions, …
50294f6 
…r=jackh726

Use revisions instead of nll compare mode for `/regions/` ui tests

Created rust-lang#96211 for the duplicated mismatched types errors

r? `@jackh726`
@jackh726 jackh726 changed the title [NLL] Duplicated mismatched types errors [NLL] Duplicated errors May 21, 2022
@jackh726 jackh726 mentioned this issue May 21, 2022
Closed
@jackh726
Copy link
Member

I've changed this issue to track duplicate errors in NLL in general, wrapping in #95686 and expanding to also include hr-subtype.rs (updated op).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marmeladema @jackh726 @rustbot