Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for RFC 3239: Add target configuration #96901

Open
1 of 3 tasks
pnkfelix opened this issue May 10, 2022 · 1 comment · May be fixed by #130780
Open
1 of 3 tasks

Tracking Issue for RFC 3239: Add target configuration #96901

pnkfelix opened this issue May 10, 2022 · 1 comment · May be fixed by #130780
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature.

Comments

@pnkfelix
Copy link
Member

pnkfelix commented May 10, 2022 •
edited by Urgau
Loading

This is a tracking issue for the RFC "3239" (rust-lang/rfcs#3239).
The feature gate for the issue is #![feature(cfg_target)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • How do we ensure a project does not miss configurations similar to the ones
    being #[cfg]-ed against with this feature? Perhaps this should be added as a
    Clippy lint that's off by default.

Implementation history
@pnkfelix pnkfelix added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label May 10, 2022
@Urgau

This comment has been minimized.

Sign in to view
This was referenced May 10, 2022
Closed
Merged
@ehuss ehuss mentioned this issue May 11, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 25, 2022
@Dylan-DPC
Rollup merge of rust-lang#96913 - Urgau:rfc3239-part2, r=petrochenkov
c12a36a 
RFC3239: Implement `cfg(target)` - Part 2

This pull-request implements the compact `cfg(target(..))` part of [RFC 3239](rust-lang#96901).

I recommend reviewing this PR on a per commit basics, because of some moving parts.

cc `@GuillaumeGomez`
r? `@petrochenkov`
@Urgau Urgau removed their assignment Sep 25, 2022
@simlay simlay mentioned this issue Apr 4, 2023
Open
@vklachkov vklachkov mentioned this issue Mar 13, 2024
Merged
@Urgau Urgau linked a pull request Sep 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unstable cfg target(...) compact feature Urgau/rust
2 participants
@pnkfelix @Urgau