Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc -Z help and -C help are still broken #98976

Closed
jyn514 opened this issue Jul 6, 2022 · 1 comment · Fixed by #99055
Closed

rustdoc -Z help and -C help are still broken #98976

jyn514 opened this issue Jul 6, 2022 · 1 comment · Fixed by #99055
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Jul 6, 2022

I tried this: rustdoc -Zhelp

I expected to see this happen: A list of unstable options

Instead, this happened:

$ rustdoc +stage1 -Zhelp
error: unknown unstable option: `help`

$ rustdoc +stage1 -Chelp
error: unknown codegen option: `help`

The options need to be built after checking for help, not before.
https://github.com/rust-lang/rust/blob/0567674460504d916c254696e1b25082f72a66bf/src/librustdoc/config.rs#L338-L355

cc @GuillaumeGomez

Meta

rustc --version --verbose: 0567674460504d916c254696e1b25082f72a66bf
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Jul 6, 2022
@GuillaumeGomez
Copy link
Member

Thanks for the feedback. I'll send a fix as soon as possible.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 8, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 10, 2022
@matthiaskrgr
Rollup merge of rust-lang#99055 - GuillaumeGomez:rustdoc-help-options…
2d220f2 
…, r=jyn514

Fix rustdoc help options

Fixes rust-lang#98976.

Since you're the one who found out about the problem and also provided the solution (thanks for both!):

r? `@jyn514`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#99055 - GuillaumeGomez:rustdoc-help-options…
f240ca0 
…, r=jyn514

Fix rustdoc help options

Fixes rust-lang#98976.

Since you're the one who found out about the problem and also provided the solution (thanks for both!):

r? `@jyn514`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 11, 2022
@matthiaskrgr
Rollup merge of rust-lang#99055 - GuillaumeGomez:rustdoc-help-options…
da85ea2 
…, r=jyn514

Fix rustdoc help options

Fixes rust-lang#98976.

Since you're the one who found out about the problem and also provided the solution (thanks for both!):

r? ``@jyn514``
@bors bors closed this as completed in c431e6f Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rustdoc help options GuillaumeGomez/rust
2 participants
@GuillaumeGomez @jyn514