-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iterator::array_chunks
(take N+1)
#100026
Changes from 10 commits
ca3d101
f548518
ef72349
b8b1486
4db628a
3102b39
37dfb04
4c0292c
475e4ba
756bd6e
eb6b729
5fbcde1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,180 @@ | ||||||||||||||||
use crate::array; | ||||||||||||||||
use crate::iter::{FusedIterator, Iterator}; | ||||||||||||||||
use crate::ops::{ControlFlow, NeverShortCircuit, Try}; | ||||||||||||||||
|
||||||||||||||||
/// An iterator over `N` elements of the iterator at a time. | ||||||||||||||||
/// | ||||||||||||||||
/// The chunks do not overlap. If `N` does not divide the length of the | ||||||||||||||||
/// iterator, then the last up to `N-1` elements will be omitted. | ||||||||||||||||
/// | ||||||||||||||||
/// This `struct` is created by the [`array_chunks`][Iterator::array_chunks] | ||||||||||||||||
/// method on [`Iterator`]. See its documentation for more. | ||||||||||||||||
#[derive(Debug, Clone)] | ||||||||||||||||
#[must_use = "iterators are lazy and do nothing unless consumed"] | ||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
pub struct ArrayChunks<I: Iterator, const N: usize> { | ||||||||||||||||
iter: I, | ||||||||||||||||
remainder: Option<array::IntoIter<I::Item, N>>, | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
impl<I, const N: usize> ArrayChunks<I, N> | ||||||||||||||||
where | ||||||||||||||||
I: Iterator, | ||||||||||||||||
{ | ||||||||||||||||
#[track_caller] | ||||||||||||||||
pub(in crate::iter) fn new(iter: I) -> Self { | ||||||||||||||||
assert!(N != 0, "chunk size must be non-zero"); | ||||||||||||||||
Self { iter, remainder: None } | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
/// Returns an iterator over the remaining elements of the original iterator | ||||||||||||||||
/// that are not going to be returned by this iterator. The returned | ||||||||||||||||
/// iterator will yield at most `N-1` elements. | ||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
#[inline] | ||||||||||||||||
pub fn into_remainder(self) -> Option<array::IntoIter<I::Item, N>> { | ||||||||||||||||
self.remainder | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
impl<I, const N: usize> Iterator for ArrayChunks<I, N> | ||||||||||||||||
where | ||||||||||||||||
I: Iterator, | ||||||||||||||||
{ | ||||||||||||||||
type Item = [I::Item; N]; | ||||||||||||||||
|
||||||||||||||||
#[inline] | ||||||||||||||||
fn next(&mut self) -> Option<Self::Item> { | ||||||||||||||||
self.try_for_each(ControlFlow::Break).break_value() | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[inline] | ||||||||||||||||
fn size_hint(&self) -> (usize, Option<usize>) { | ||||||||||||||||
let (lower, upper) = self.iter.size_hint(); | ||||||||||||||||
|
||||||||||||||||
(lower / N, upper.map(|n| n / N)) | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[inline] | ||||||||||||||||
fn count(self) -> usize { | ||||||||||||||||
self.iter.count() / N | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
fn try_fold<B, F, R>(&mut self, init: B, mut f: F) -> R | ||||||||||||||||
where | ||||||||||||||||
Self: Sized, | ||||||||||||||||
F: FnMut(B, Self::Item) -> R, | ||||||||||||||||
R: Try<Output = B>, | ||||||||||||||||
{ | ||||||||||||||||
let mut acc = init; | ||||||||||||||||
loop { | ||||||||||||||||
match self.iter.next_chunk() { | ||||||||||||||||
Ok(chunk) => acc = f(acc, chunk)?, | ||||||||||||||||
Err(remainder) => { | ||||||||||||||||
// Make sure to not override `self.remainder` with an empty array | ||||||||||||||||
// when `next` is called after `ArrayChunks` exhaustion. | ||||||||||||||||
self.remainder.get_or_insert(remainder); | ||||||||||||||||
|
||||||||||||||||
break try { acc }; | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
fn fold<B, F>(mut self, init: B, mut f: F) -> B | ||||||||||||||||
where | ||||||||||||||||
Self: Sized, | ||||||||||||||||
F: FnMut(B, Self::Item) -> B, | ||||||||||||||||
{ | ||||||||||||||||
self.try_fold(init, |acc, x| NeverShortCircuit(f(acc, x))).0 | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
impl<I, const N: usize> DoubleEndedIterator for ArrayChunks<I, N> | ||||||||||||||||
where | ||||||||||||||||
I: DoubleEndedIterator + ExactSizeIterator, | ||||||||||||||||
{ | ||||||||||||||||
#[inline] | ||||||||||||||||
fn next_back(&mut self) -> Option<Self::Item> { | ||||||||||||||||
self.try_rfold((), |(), x| ControlFlow::Break(x)).break_value() | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
fn try_rfold<B, F, R>(&mut self, init: B, mut f: F) -> R | ||||||||||||||||
where | ||||||||||||||||
Self: Sized, | ||||||||||||||||
F: FnMut(B, Self::Item) -> R, | ||||||||||||||||
R: Try<Output = B>, | ||||||||||||||||
{ | ||||||||||||||||
// We are iterating from the back we need to first handle the remainder. | ||||||||||||||||
self.next_back_remainder(); | ||||||||||||||||
|
||||||||||||||||
let mut acc = init; | ||||||||||||||||
let mut iter = self.iter.by_ref().rev(); | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: You have a |
||||||||||||||||
|
||||||||||||||||
// NB remainder is handled by `next_back_remainder`, so | ||||||||||||||||
// `next_chunk` can't return `Err` with non-empty remainder | ||||||||||||||||
// (assuming correct `I as ExactSizeIterator` impl). | ||||||||||||||||
while let Ok(mut chunk) = iter.next_chunk() { | ||||||||||||||||
chunk.reverse(); | ||||||||||||||||
acc = f(acc, chunk)? | ||||||||||||||||
} | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Imo we either need a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sorry you had to see this impl 😅 |
||||||||||||||||
|
||||||||||||||||
try { acc } | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
fn rfold<B, F>(mut self, init: B, mut f: F) -> B | ||||||||||||||||
where | ||||||||||||||||
Self: Sized, | ||||||||||||||||
F: FnMut(B, Self::Item) -> B, | ||||||||||||||||
{ | ||||||||||||||||
self.try_rfold(init, |acc, x| NeverShortCircuit(f(acc, x))).0 | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
impl<I, const N: usize> ArrayChunks<I, N> | ||||||||||||||||
where | ||||||||||||||||
I: DoubleEndedIterator + ExactSizeIterator, | ||||||||||||||||
{ | ||||||||||||||||
/// Updates `self.remainder` such that `self.iter.len` is divisible by `N`. | ||||||||||||||||
fn next_back_remainder(&mut self) { | ||||||||||||||||
// Make sure to not override `self.remainder` with an empty array | ||||||||||||||||
// when `next_back` is called after `ArrayChunks` exhaustion. | ||||||||||||||||
if self.remainder.is_some() { | ||||||||||||||||
return; | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
// We use the `ExactSizeIterator` implementation of the underlying | ||||||||||||||||
// iterator to know how many remaining elements there are. | ||||||||||||||||
let rem = self.iter.len() % N; | ||||||||||||||||
|
||||||||||||||||
// Take the last `rem` elements out of `self.iter`. | ||||||||||||||||
let mut remainder = | ||||||||||||||||
// SAFETY: `unwrap_err` always succeeds because x % N < N for all x. | ||||||||||||||||
unsafe { self.iter.by_ref().rev().take(rem).next_chunk().unwrap_err_unchecked() }; | ||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think I'll block the PR on this, but My instinct for now is that (At least the obvious things, like a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As already noted in another comment I don't like this entire method. Either we should add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So, an evil impl can return less than An evil impl can just return a wrong length, so after this iterator returns a number of elements not divisible by rust/library/core/src/iter/adapters/array_chunks.rs Lines 116 to 119 in 5fbcde1
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That being said, as @the8472 already said, we should probably rewrite the DEI impl anyway (I'll try to do this, after this lands). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, the But I agree that just making a nicer implementation without the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually you are right 😨 Overriding
rust/library/core/src/iter/adapters/take.rs Lines 87 to 89 in 2fbc08e
The fact that unsafe code can't trust There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the problem there is still in the But yeah, even though I've not been able to come up with a safe trick that would do it, things along those lines are what make me worried about it. (And certainly if specialization existed then it would be possible to do particularly weird things in safe code because it can violate parametricity even worse than in normal code.) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The example could check, that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I thought about that one, but |
||||||||||||||||
|
||||||||||||||||
// We used `.rev()` above, so we need to re-reverse the reminder | ||||||||||||||||
remainder.as_mut_slice().reverse(); | ||||||||||||||||
self.remainder = Some(remainder); | ||||||||||||||||
} | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
impl<I, const N: usize> FusedIterator for ArrayChunks<I, N> where I: FusedIterator {} | ||||||||||||||||
|
||||||||||||||||
#[unstable(feature = "iter_array_chunks", reason = "recently added", issue = "none")] | ||||||||||||||||
impl<I, const N: usize> ExactSizeIterator for ArrayChunks<I, N> | ||||||||||||||||
where | ||||||||||||||||
I: ExactSizeIterator, | ||||||||||||||||
{ | ||||||||||||||||
#[inline] | ||||||||||||||||
fn len(&self) -> usize { | ||||||||||||||||
self.iter.len() / N | ||||||||||||||||
} | ||||||||||||||||
|
||||||||||||||||
#[inline] | ||||||||||||||||
fn is_empty(&self) -> bool { | ||||||||||||||||
self.iter.len() < N | ||||||||||||||||
} | ||||||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid making a closure type generic over
I
too:(and the same in
rfold
)