add method to get the mutability of an AllocId #100181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
alloc-ref-mutability
branch
from
6b625cd to
36533d7
Compare
rustbot
added
the
T-bootstrap
RalfJung
changed the title
RalfJung
force-pushed
the
alloc-ref-mutability
branch
from
36533d7 to
72e5d53
Compare
RalfJung
force-pushed
the
alloc-ref-mutability
branch
from
72e5d53 to
54b122e
Compare
|
@lcnr maybe I could ask you to take a look at this one? |
jackh726
reviewed
Aug 7, 2022
Comment on lines
+631
to
+634
| // propagate --bless | ||
| if builder.config.cmd.bless() { | ||
| cargo.env("MIRI_BLESS", "Gesundheit"); | ||
| } |
There was a problem hiding this comment.
Yeah it is. It makes Miri's test suite bless work with x.py --bless. Didn't seem significant enough for its own PR, but I can split it if you prefer.
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 8, 2022
…ackh726 add method to get the mutability of an AllocId Miri needs this for rust-lang/miri#2463.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 9, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#96478 (Implement `#[rustc_default_body_unstable]`) - rust-lang#99787 (Rustdoc-Json: Document HRTB's on DynTrait) - rust-lang#100181 (add method to get the mutability of an AllocId) - rust-lang#100221 (Don't document impossible to call default trait items on impls) - rust-lang#100228 (Don't ICE while suggesting updating item path.) - rust-lang#100301 (Avoid `&str` to `String` conversions) - rust-lang#100305 (Suggest adding an appropriate missing pattern excluding comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Aug 9, 2022
Atomics must be mutable Fixes #2463 Needs rust-lang/rust#100181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miri needs this for rust-lang/miri#2463.