-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention as_mut
alongside as_ref
in borrowck error message
#100186
Conversation
r? @fee1-dead (rust-highfive has picked a reviewer for you, use r? to override) |
fn_call_span.shrink_to_lo(), | ||
"consider calling `.as_ref()` to borrow the type's contents", | ||
"consider calling `.as_ref()` or `.as_mut()` to borrow the type's contents", | ||
"as_ref().", | ||
Applicability::MachineApplicable, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the user has a choice. So should we be making this MachineApplicable
? Thinking of it again, should it be a suggestion at all or just a span_help
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't even notice this was MachineApplicable. Yeah, it shouldn't. I could probably bump it down and make the suggestion inline, not verbose like it's rendering now
2987f15
to
e37565d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the late review.
@bors r+ |
@bors rollup |
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#100186 (Mention `as_mut` alongside `as_ref` in borrowck error message) - rust-lang#100383 (Mitigate stale data reads on SGX platform) - rust-lang#100507 (suggest `once_cell::Lazy` for non-const statics) - rust-lang#100617 (Suggest the right help message for as_ref) - rust-lang#100667 (Migrate "invalid variable declaration" errors to SessionDiagnostic) - rust-lang#100709 (Migrate typeck's `used` expected symbol diagnostic to `SessionDiagnostic`) - rust-lang#100723 (Add the diagnostic translation lints to crates that don't emit them) - rust-lang#100729 (Avoid zeroing a 1kb stack buffer on every call to `std::sys::windows::fill_utf16_buf`) - rust-lang#100750 (improved diagnostic for function defined with `def`, `fun`, `func`, or `function` instead of `fn`) - rust-lang#100763 (triagebot: Autolabel `A-rustdoc-json`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Kinda fixes #99426 but I guess that really might be better staying open to see if we could make it suggest
as_mut
in a structured way. Not sure how to change borrowck to know that info tho.