-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink AST items #100363
Shrink AST items #100363
Conversation
Some of these don't need a `use` statement because there is already a `#[macro_use] extern crate rustc_data_structures` item in the crate.
It has four arguments that are never used. This avoids lots of argument passing in functions that feed into `visit_variant_data`.
It's passed three arguments that are never used.
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit c0a3752 with merge 7adcd665de8f8641e88434fadbfd09393b0bedee... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
dc5c3e5
to
0e9ea62
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 0e9ea62 with merge 0a2103a2fa8ce8fbf5460cc416160bbd7409a2b3... |
☀️ Try build successful - checks-actions |
Queued 0a2103a2fa8ce8fbf5460cc416160bbd7409a2b3 with parent 1603a70, future comparison URL. |
Finished benchmarking commit (0a2103a2fa8ce8fbf5460cc416160bbd7409a2b3): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
Pretty weak results here. I've subsequently made measurements that show |
r? @ghost