Rollup of 7 pull requests #100395

Dylan-DPC · 2022-08-11T05:44:58Z

Successful merges:

Check if enum from foreign crate has any non exhaustive variants when attempting a cast #92744 (Check if enum from foreign crate has any non exhaustive variants when attempting a cast)
rustdoc: simplify highlight.rs #99337 (rustdoc: simplify highlight.rs)
Never inline Windows dtor access #100007 (Never inline Windows dtor access)
cleanup code w/ pointers in std a little #100030 (cleanup code w/ pointers in std a little)
Remove duplicated temporaries creating during box derefs elaboration #100192 ( Remove duplicated temporaries creating during box derefs elaboration)
Generalize trait object generic param check to aliases. #100247 (Generalize trait object generic param check to aliases.)
Improve crate selection on rustdoc search results page #100374 (Improve crate selection on rustdoc search results page)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Temporaries created with `MirPatch::new_temp` will be declared after patch application. Remove manually created duplicate declarations. Removing duplicates exposes another issue. Visitor elaborates terminator twice and attempts to access new, but not yet available, local declarations. Remove duplicated call to `visit_terminator`.

Split render_with_highlighting, which took many optional parameters, into three functions for specific purposes, which each take a smaller number of mostly required parameters. Remove some plumbing to pass through an "edition" parameter, which was used solely to avoid highlighting some 2021 Edition keywords in non-2021 code.

Resolves all of issue rust-lang#93240 Reproduces a similar change as rust-lang#99086, but with improvements In particular, this PR inlcludes: * redesigning the crate-search selector so the background color matches its surroundings * decrease the font of the dropdown menu to a reaonable size * add a hover effect * make the color of the arrow theme-dependent, using a surrounding div, with :after pseudo-element that can then be transformed using CSS filters to approximate the desired color * fix the text "in" to match the title font * remove the "for xyz" in the "Results for xyz in [All crates]" title when searching for search term "xyz"; you can already see what you're searching for as it's typed in the search bar! * in line with rust-lang#99086, handle super-long crate names appropriately without a long <select> element escaping the screen area; the improvement is that we also keep the title within a single line now; uses some flex layout shenanigans... * the margins / paddings are adjusted so the selected label of the <select> fits within the rest of that title nicely; also some inconsistency in the way that Firefox renders a <select> with "appearance: none" (roughly 4px more padding left and right of the text than e.g. Chrome) is worked around, and it now produces a result that looks (essentially) identical to Chrome * the color of the help menu and settings menu border in light theme is made to match with the color of the corresponding buttons, like they do (match) in the ayu theme * the casing of "All crates" changes to "all crates" * the new tests from rust-lang#99086 are temporarily disabled, until they can be adapted later

Fix oversight duplicate property left in CSS (dark theme). Improve wording in comment that mentions `appearance: none`

…non_exhaustive

…eign-variants, r=scottmcm Check if enum from foreign crate has any non exhaustive variants when attempting a cast Fixes rust-lang#91161 As stated in the issue, this will require a crater run as it might break other people's stuff.

…eGomez rustdoc: simplify highlight.rs Split render_with_highlighting, which took many optional parameters, into three functions for specific purposes, which each take a smaller number of mostly required parameters. Remove some plumbing to pass through an "edition" parameter, which was used solely to avoid highlighting some 2021 Edition keywords in non-2021 code. I've tested a build of std docs before and after, and this does not change the generated HTML at all. Followup from rust-lang#91264 (comment) r? ``@GuillaumeGomez``

…ichaelwoerister Never inline Windows dtor access Inlining can cause problem If used in a Rust dylib. See rust-lang#44391. r? `@Mark-Simulacrum`

…cottmcm cleanup code w/ pointers in std a little Use pointer methods (`byte_add`, `null_mut`, etc) to make code in std a little nicer.

…gisa Remove duplicated temporaries creating during box derefs elaboration Temporaries created with `MirPatch::new_temp` will be declared after patch application. Remove manually created duplicate declarations. Removing duplicates exposes another issue. Visitor elaborates terminator twice and attempts to access new, but not yet available, local declarations. Remove duplicated call to `visit_terminator`. Extracted from rust-lang#99946.

…faults, r=lcnr Generalize trait object generic param check to aliases. The current algorithm only checks that `Self` does not appear in defaults for traits. This is not sufficient for trait aliases. This PR moves the check to trait object elaboration, which sees through trait aliases. Fixes rust-lang#82927. Fixes rust-lang#84789.

…rch_results_page_crates_selection, r=notriddle Improve crate selection on rustdoc search results page Take over of rust-lang#98855 (screenshots and explanations are there). You can test it [here](https://rustdoc.crud.net/imperio/improve_rustdoc_search_results_page_crates_selection/std/index.html?search=test). cc `@steffahn` `@jsha` r? `@notriddle`

Dylan-DPC · 2022-08-11T05:45:15Z

@bors r+ rollup=never p=5

bors · 2022-08-11T05:45:17Z

📌 Commit 5a5cd6b has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2022-08-11T06:10:14Z

⌛ Testing commit 5a5cd6b with merge c660fd911b3665559e15c3002e53b6d74bfbf3c3...

bors · 2022-08-11T10:25:14Z

💥 Test timed out

rust-log-analyzer · 2022-08-11T10:55:58Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Dylan-DPC · 2022-08-11T11:04:28Z

@bors retry

bors · 2022-08-11T13:29:21Z

⌛ Testing commit 5a5cd6b with merge a6c7b9d05df9c1962e73c5ecc056d26bcbb36db4...

bors · 2022-08-11T17:44:22Z

💥 Test timed out

rust-log-analyzer · 2022-08-11T18:15:43Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2022-08-19T23:08:33Z

☔ The latest upstream changes (presumably #100740) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2022-09-02T03:16:38Z

⌛ Testing commit 5a5cd6b with merge 3013480...

bors · 2022-09-02T05:32:50Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 3013480 to master...

rust-timer · 2022-09-02T06:53:11Z

Finished benchmarking commit (3013480): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.7%	[2.4%, 3.0%]	2
Regressions ❌ (secondary)	4.0%	[3.1%, 4.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	2.7%	[2.4%, 3.0%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

ChrisDenton and others added 22 commits August 1, 2022 03:53

Never inline Windows dtor access

847f461

cleanup code w/ pointers in std a little

127b6c4

improve documentation of pointer::align_offset

a7c45ec

./x.py test --bless

7d2131a

move an assert! to the right place

d52ed82

Two small improvements:

e957480

Fix oversight duplicate property left in CSS (dark theme). Improve wording in comment that mentions `appearance: none`

Add missing ID into the ID map

107e039

Update GUI test

ea05be2

Generalize trait object generic param check to aliases.

e1e25a8

Ban indirect references to Self too.

0df84ae

Check if extern crate enum has non exhaustive variant when cast

a3b84ad

Update error message to clarify that it's not the enum itself that's …

dfb3713

…non_exhaustive

Rollup merge of rust-lang#100007 - ChrisDenton:dtor-inline-never, r=m…

5b2ad6e

…ichaelwoerister Never inline Windows dtor access Inlining can cause problem If used in a Rust dylib. See rust-lang#44391. r? `@Mark-Simulacrum`

Rollup merge of rust-lang#100030 - WaffleLapkin:nice_pointer_sis, r=s…

8bdb414

…cottmcm cleanup code w/ pointers in std a little Use pointer methods (`byte_add`, `null_mut`, etc) to make code in std a little nicer.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 2, 2022

bors merged commit 3013480 into rust-lang:master Sep 2, 2022

rustbot added this to the 1.65.0 milestone Sep 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 7 pull requests #100395

Rollup of 7 pull requests #100395

Dylan-DPC commented Aug 11, 2022

Dylan-DPC commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

Dylan-DPC commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

bors commented Aug 19, 2022

bors commented Sep 2, 2022

bors commented Sep 2, 2022

rust-timer commented Sep 2, 2022

Rollup of 7 pull requests #100395

Rollup of 7 pull requests #100395

Conversation

Dylan-DPC commented Aug 11, 2022

Dylan-DPC commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

Dylan-DPC commented Aug 11, 2022

bors commented Aug 11, 2022

bors commented Aug 11, 2022

rust-log-analyzer commented Aug 11, 2022

bors commented Aug 19, 2022

bors commented Sep 2, 2022

bors commented Sep 2, 2022

rust-timer commented Sep 2, 2022

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes