Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require stabilizations to use a placeholder instead of writing out stabilization version #100591

Merged
merged 7 commits into from
Aug 27, 2022
Merged

Require stabilizations to use a placeholder instead of writing out stabilization version #100591

merged 7 commits into from
Aug 27, 2022
+271 −86

Commits on Aug 27, 2022

  1. tidy: forbid since values for features that point to the current rele… 

    …ase or future ones

It's a common phenomenon that feature stabilizations don't make it into
a particular release, but the version is still inaccurate. Often this
leads to subsequent changes to adjust/correct the version.

Instead, require people to put a placeholder that gets replaced during
beta branching time with the current rust version. That way, there is
no chance that an error can be introduced.

Usage of the placeholder is required on the nightly channel, and forbidden
on the stable and beta channels.
    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    d06e0e5 View commit details
    Browse the repository at this point in the history

  2. Expand the version placeholder to the current version in stability at… 

    …tribute parsing

That way, the current version is shown in rustdoc etc.
    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    7a5b1d7 View commit details
    Browse the repository at this point in the history

  3. Adjust ptr_const_cast stabilization version to CURRENT_RUSTC_VERSION

    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    e576a9b View commit details
    Browse the repository at this point in the history

  4. Adjust backtrace stabilization version to CURRENT_RUSTC_VERSION

    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    6e4e3e8 View commit details
    Browse the repository at this point in the history

  5. Adjust label break value stabilization version to CURRENT_RUSTC_VERSION

    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    4caedba View commit details
    Browse the repository at this point in the history

  6. tidy: move directory traversal utility functions into dedicated module

    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    a2e2d76 View commit details
    Browse the repository at this point in the history

  7. Add replace-version-placeholder tool 

    This tool is to be ran at specific points in the release process to replace
the version place holder made by stabilizations with the version number.
    @est31
    est31 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    d32ff14 View commit details
    Browse the repository at this point in the history