Minor syntax and formatting update to doc comment on find_vtable_types_for_unsizing
#100697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
address nit and squash into one commit, then r=me |
|
✌️ @eholk can now approve this pull request |
eholk
force-pushed
the
doc-comment-update
branch
from
ebf04f7
to
31bcbb0
Compare
|
@bors r=compiler-errors |
|
📌 Commit 31bcbb0c60da5783c9b1821e37dde288d9d9ecb4 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- |
bors
added
S-waiting-on-author
The comment is on find_vtable_types_for_unsizing, but there is another unrelated typo fix as well.
eholk
force-pushed
the
doc-comment-update
branch
from
31bcbb0
to
8b7b1f7
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 21, 2022
…er-errors Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing` I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 21, 2022
…er-errors Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing` I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 21, 2022
…er-errors Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing` I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 21, 2022
…er-errors Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing` I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 21, 2022
…er-errors Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing` I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.
This was referenced Aug 21, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2022
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#100556 (Clamp Function for f32 and f64) - rust-lang#100663 (Make slice::reverse const) - rust-lang#100697 ( Minor syntax and formatting update to doc comment on `find_vtable_types_for_unsizing`) - rust-lang#100760 (update test for LLVM change) - rust-lang#100761 (some general mir typeck cleanup) - rust-lang#100775 (rustdoc: Merge source code pages HTML elements together v2) - rust-lang#100813 (Add `/build-rust-analyzer/` to .gitignore) - rust-lang#100821 (Make some docs nicer wrt pointer offsets) - rust-lang#100822 (Replace most uses of `pointer::offset` with `add` and `sub`) - rust-lang#100839 (Make doc for stdin field of process consistent) - rust-lang#100842 (Add diagnostics lints to `rustc_transmute` module (zero diags)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the code examples on this function weren't formatted as code, and also the that the syntax for trait objects was out of date (or just incorrect). This should bring it up to date.