Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incremental: migrate diagnostics #100754

Merged
merged 5 commits into from
Jan 31, 2023
Merged

incremental: migrate diagnostics #100754

merged 5 commits into from
Jan 31, 2023

Commits on Jan 30, 2023

  1. errors: add emit_note/create_note on Handler 

    Support for emission of notes was added in f8ebc72 but `emit_note` and
`create_note` functions weren't added to `Handler`.

Signed-off-by: David Wood <david.wood@huawei.com>
    @davidtwco
    davidtwco committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    59cc5e5 View commit details
    Browse the repository at this point in the history

  2. errors: implement IntoDiagnosticArg for &T 

    Implement `IntoDiagnosticArg` for `&'a T` when `T` implements
`IntoDiagnosticArg` and `Clone`. Makes it easier to write diagnostic
structs that borrow something which implements `IntoDiagnosticArg`.

Signed-off-by: David Wood <david.wood@huawei.com>
    @davidtwco
    davidtwco committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f7b4210 View commit details
    Browse the repository at this point in the history

  3. session: impl IntoDiagnosticArg for CrateType 

    Forward the `Display` implementation for `CrateType` to
`IntoDiagnosticArg` so that it can be used in diagnostic structs.

Signed-off-by: David Wood <david.wood@huawei.com>
    @davidtwco
    davidtwco committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d450048 View commit details
    Browse the repository at this point in the history

  4. session: diagnostic migration lint on more fns 

    Apply the diagnostic migration lint to more functions on `Session`.

Signed-off-by: David Wood <david.wood@huawei.com>
    @davidtwco
    davidtwco committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2575b1a View commit details
    Browse the repository at this point in the history

  5. incremental: migrate diagnostics 

    Migrate the `rustc_incremental` crate's diagnostics to translatable
diagnostic structs.

Signed-off-by: David Wood <david.wood@huawei.com>
    @davidtwco
    davidtwco committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2ff4664 View commit details
    Browse the repository at this point in the history