Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the message for parser_incorrect_semicolon #100788

Closed
wants to merge 1 commit into from
Closed

Improve the message for parser_incorrect_semicolon #100788

wants to merge 1 commit into from

Conversation

reez12g
Copy link
Contributor

@reez12g reez12g commented Aug 20, 2022

fixes #100607

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2022
@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2022
@Rageking8
Copy link
Contributor

@rustbot -A-translation

@compiler-errors
Copy link
Member

I don't think the message you edited is actually the change you want to make. See the CI failure:

9	   |
10	LL | struct S {};
-	   |            ^ help: remove this semicolon
+	   |            ^ help: remove this semicolon for implicit return
12	   |

@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-diagnostics Area: Messages for errors, warnings, and lints and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Aug 20, 2022
@Rageking8
Copy link
Contributor

@reez12g Are you still working on this?

@Rageking8
Copy link
Contributor

Due to @reez12g inactivity for this PR, I went ahead and proceeded to create another PR to resolve the issue(#100607): #102650. Hence, I believe this PR can be closed. Thanks.

@Rageking8
Copy link
Contributor

@compiler-errors sorry for the ping, but can you close this PR as complete since it's just an inactive duplicate of #102650 which has already been merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slightly improve no return for returning function error
6 participants
@reez12g @rust-highfive @Rageking8 @compiler-errors @estebank @rustbot