-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF] Normalize opaques with escaping bound vars in AssocTypeNormalizer #100903
[PERF] Normalize opaques with escaping bound vars in AssocTypeNormalizer #100903
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a715948 with merge 41b4519665e895f6ac8cf481e8f8189567b04230... |
I'm so stupid. This won't work. QueryNormalizer and AssocTypeNormalizer need to agree, otherwise UI tests get angry. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
The issue in #88862 mentioned the
QueryNormalizer
as the source of too many bound vars, not theAssocTypeNormalizer
... maybe just reverting this one and keeping the otherif !substs.has_escaping_bound_vars()
will satisfy perf + let us fix the ICE in rust-lang/miri#2433. I may have no idea what I'm doing though.r? @ghost